You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opening a draft PR to get fresh eyes on my new DD code. We can now handle decomposed mesh tallies of varying sizes, and the dd_slab_reed test should pass when run with 4 processors. Currently working on getting dd_slab_reed and dd_cooper to pass when run with multiple processors per subdomain; from there, we should be able to add non-uniform work ratios fairly easily.
Apparently I wasn't running on the most up-to-date version of dev; as a result, it looks like the DD code isn't working. I'll look into it and see if I can figure out where the issue is.
The tally values I get from this version are identical to the ones I was getting on my branch; this made me wonder if the answer.h5 file had somehow changed. Running the dd_slab_reed problem without domain decomposition, and using that output as the answer.h5 for the regression test, causes the test to pass again. It's possible that the changes I made to the dd_slab_reed input caused its output to change from the existing version, but since the new version is accurate to a non-DD simulation, I believe it is the correct output.
The dd_slab_reed test succeeds in Python and Numba modes on my Dane build; the tests fail on Github because it is trying to run with only 1 processor. Not sure why that's happening; my only guess is it's a difference between calling --mpiexec and --srun?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a draft PR to get fresh eyes on my new DD code. We can now handle decomposed mesh tallies of varying sizes, and the
dd_slab_reedtest should pass when run with 4 processors. Currently working on gettingdd_slab_reedanddd_cooperto pass when run with multiple processors per subdomain; from there, we should be able to add non-uniform work ratios fairly easily.