importer: Populate eitem_type in EItem object

cds_ils/importer/eitems/importer.py

@@ -203,6 +203,7 @@ def _build_eitem_json(self, eitem_json, document_pid, urls=None, description=Non
  eitem_json.update(
  dict(
  document_pid=document_pid,
+ eitem_type=self.eitem_json.get("_type", "E-BOOK").upper(),
  open_access=self.open_access,
  identifiers=dois,
  urls=self.eitem_json.get("urls", []),

tests/importer/data/existing_eitems.json

@@ -3,6 +3,7 @@
  "pid": "eitemid-1",
  "created_by": {"type": "script", "value": "test"},
  "document_pid": "docid-2",
+ "eitem_type": "E-BOOK",
  "internal_notes": "An internal note",
  "description": "Description of the electronic item",
  "open_access": true
@@ -11,6 +12,7 @@
  "pid": "eitemid-2",
  "created_by": {"type": "script", "value": "test"},
  "document_pid": "docid-2",
+ "eitem_type": "E-BOOK",
  "internal_notes": "An internal note",
  "description": "Description of the electronic item",
  "open_access": false,
@@ -31,6 +33,7 @@
  "pid": "eitemid-3",
  "created_by": {"type": "import", "value": "springer"},
  "document_pid": "docid-3",
+ "eitem_type": "E-BOOK",
  "internal_notes": "EITEM TO MODIFY",
  "description": "Description of the electronic item",
  "open_access": false,
@@ -51,6 +54,7 @@
  "pid": "eitemid-4",
  "created_by": {"type": "import", "value": "ebl"},
  "document_pid": "docid-1",
+ "eitem_type": "E-BOOK",
  "internal_notes": "An internal note",
  "description": "Description of the electronic item",
  "open_access": false,
@@ -71,6 +75,7 @@
  "pid": "eitemid-6",
  "created_by": {"type": "import", "value": "ebl"},
  "document_pid": "docid-6",
+ "eitem_type": "E-BOOK",
  "internal_notes": "An internal note",
  "description": "Description of the electronic item",
  "open_access": false,
@@ -91,6 +96,7 @@
  "pid": "eitemid-6A",
  "created_by": {"type": "import", "value": "safari"},
  "document_pid": "docid-6A",
+ "eitem_type": "E-BOOK",
  "internal_notes": "An internal note",
  "description": "Description of the electronic item",
  "open_access": false,
@@ -111,6 +117,7 @@
  "pid": "eitemid-7",
  "created_by": {"type": "import", "value": "springer"},
  "document_pid": "docid-7",
+ "eitem_type": "E-BOOK",
  "internal_notes": "An internal note",
  "description": "Description of the electronic item",
  "open_access": false,
@@ -131,6 +138,7 @@
  "pid": "eitemid-8",
  "created_by": {"type": "user", "value": "1"},
  "document_pid": "docid-8",
+ "eitem_type": "E-BOOK",
  "internal_notes": "An internal note",
  "description": "Description of the electronic item",
  "open_access": false,
@@ -151,6 +159,7 @@
  "pid": "eitemid-9",
  "created_by": {"type": "user", "value": "1"},
  "document_pid": "docid-9",
+ "eitem_type": "AUDIOBOOK",
  "internal_notes": "An internal note",
  "description": "Description of the electronic item",
  "open_access": false,

tests/importer/data/modify_document_data.json

@@ -14,6 +14,7 @@
  {"scheme": "ISBN", "value": "0987654321"}],
  "_eitem": {
  "pid": "eitmid-1",
+ "eitem_type": "E-BOOK",
  "created_by": {"type": "script", "value": "springer"},
  "internal_notes": "Modified",
  "description": "Modified description",
@@ -47,6 +48,7 @@
  "identifiers": [{ "scheme": "ISBN", "value": "0123456789" }],
  "_eitem": {
  "pid": "eitmid-1",
+ "eitem_type": "E-BOOK",
  "created_by": {"type": "script", "value": "springer"},
  "document_pid": "docid-1",
  "internal_notes": "Modified",

tests/importer/test_importer.py

@@ -68,6 +68,7 @@ def test_import_audiobook_with_existing_ebook(importer_test_data):
  eitem = eitem_cls.get_record_by_pid(created_eitem_pid)
 
  assert eitem["document_pid"] == updated_document["pid"]
+ assert eitem["eitem_type"] == "AUDIOBOOK"
 
  assert "_eitem" not in updated_document
  assert "agency_code" not in updated_document
@@ -100,10 +101,14 @@ def test_import_documents(app, db):
  eitem = eitem_cls.get_record_by_pid(eitem_pid)
 
  assert eitem["document_pid"] == document["pid"]
+ assert eitem["eitem_type"] == "E-BOOK"
 
  assert "_eitem" not in document
  assert "agency_code" not in document
 
+ for urls in eitem["urls"]:
+ urls["description"] == "e-book"
+
  assert eitem["created_by"] == {"type": "import", "value": "springer"}
  assert document["created_by"] == {"type": "import", "value": "springer"}
 
@@ -211,11 +216,15 @@ def test_import_audiobook(app, db):
  eitem = eitem_cls.get_record_by_pid(eitem_pid)
 
  assert eitem["document_pid"] == created_document["pid"]
+ assert eitem["eitem_type"] == "AUDIOBOOK"
 
  assert "_eitem" not in created_document
  assert "agency_code" not in created_document
  assert "identifiers" in created_document
 
+ for urls in eitem["urls"]:
+ urls["description"] == "audiobook"
+
  for isbn in created_document["identifiers"]:
  assert isbn["material"] == "AUDIOBOOK"