INSPIRE harvester: add reader component #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
reviewed
Feb 4, 2025
kpsherva
reviewed
Feb 5, 2025
| self._inspire_id = inspire_id | ||
| super().__init__(origin, mode, *args, **kwargs) | ||
|
|
||
| def _validate_date_format(self, date): |
There was a problem hiding this comment.
isn't date validated by the args schema? Do we need an additional validator?
There was a problem hiding this comment.
No it is actually not validating the input data, so we need to add the manual validation
anikachurilova
force-pushed
the
harvester-reader
branch
2 times, most recently
from
4c76496 to
5fe2b89
Compare
zzacharo
reviewed
Feb 6, 2025
|
|
||
| def read(self, item=None, *args, **kwargs): | ||
| """Builds a query depending on the input data.""" | ||
| self._validate_input_args() |
There was a problem hiding this comment.
shouldn't we utilize the InspireArgsSchema to validate the args? I.e. delegate the validation to the marshmallow schema.
anikachurilova
force-pushed
the
harvester-reader
branch
3 times, most recently
from
b737f4b to
8e3a080
Compare
* configure and register the corresponding invenio-job * create the Reader component * draft of the Transformer component * closes CERNDocumentServer#322
anikachurilova
force-pushed
the
harvester-reader
branch
from
8e3a080 to
f90664a
Compare
kpsherva
approved these changes
Feb 10, 2025
zzacharo
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the args in the UI:
