Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set limit of tags returned by TagListResource #960

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Jul 12, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

TagListResource returns all tags matching provided prefix without any limitation. It's especially expensive when we provide a very common prefix e.g. "feed:" or "ripped:"

What is the new behaviour?

  • Added count argument to the endpoint
  • count is set by default to 20 in "Add tag" autocompletion list

@psrok1 psrok1 merged commit db068aa into master Jul 12, 2024
12 checks passed
@psrok1 psrok1 deleted the feature/tag-list-limit branch July 12, 2024 16:03
@psrok1 psrok1 mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant