-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CVSS-based (v1, v2, v3) decision points as python classes #343
Add CVSS-based (v1, v2, v3) decision points as python classes #343
Conversation
…SSVC v1, v2, v2.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm flagging some things here but the general question is about how we are applying SSVC decision point versioning.
If we accept any CVSS metric name change as a new object, we are essentially assuming that CVSS only changes names when the major/minor/patch version rules introduced in #350 don't apply. I do not believe that's the case, I think CVSS has changed metric names for messaging reasons. These are valid reasons, but they differ from our agreed SSVC decision point versioning rules. If we are properly integrating CVSS metrics as SSVC decision points, I suggest we apply our own versioning rules (which I think means we do not treat a metric name change as automatically a new object).
If this reasoning holds, AV and AC are the only ones it applies to here. It will come up again from v3 to v4.
Depends on
Adds Decision Point and Decision Point Group models for CVSS v1, v2, and v3 vectors.
Includes unit tests to validate output against json schema from #340.