-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSVC JSON Schema 2020-12 #654
Conversation
- change `definitions`to `$defs`
Hello @tschmidtb51 I believe we have avoided $defs due to some limitations with CVE program not being able to have $ character in their schemas due to some restrictions in AWS implementation of MongoDB. Do you require $defs specifically or is it a design preference? Let us know we are happy to support what will work for multiple consumers that can adopt our metrics. Thanks |
It looks like we are using $refs anyway as a key. May need to discuss with CVE schema to make sure there are no issues/concerns. And it looks like the https://json-schema.org/draft/2020-12/schema states
|
Yeh after looking through Amazon documentation and CVE AWG implementation, this is not a concern. It looks like it is only a problem for generated and stored values from the schema that cannot have $ sign in their key values. So I will go ahead and approve the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the test cases run okay we should publish this and later also push the main to publish for our website.
- addresses parts of oasis-tcs#803 - update referenced SSVC schema to reflect change from CERTCC/SSVC#654 - reformat JSON schema
definitions
to$defs