Fix unit test netCDF detection and NAG support. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes use of the FindNETCDF CMake module to detect the
netCDF library for unit tests. It also fixes some files that prevented
the tests from running with the NAG compiler.
This commit BREAKS support for NAG on goldbach, but that machine is on
its way out. When the successor machine comes online, a working NAG 6.0
port will be added.
Testing:
Test suite: Unit tested only.
Baseline: N/A
Namelist changes: None
Status: bit for bit
Code reviews:
None yet.
Closed
quantheory
force-pushed
the
cime_unit_test_cleanup
branch
from
c6f0e1f to
53f3c26
Compare
Since pFUnit manages MPI itself, it's difficult to write the unit tests
to work with both pFUnit built with MPI, and with serial pFUnit and
mpi-serial. For now, we simply require use of a parallel pFUnit and an
MPI compiler.
Testing:
Test suite: Unit tested only
Baseline: N/A
Namelist changes: None
Status: bit for bit
Code reviews:
None yet.
quantheory
force-pushed
the
cime_unit_test_cleanup
branch
from
53f3c26 to
d007e2e
Compare
|
Hi Sean, If we build all of the libraries consistently I don't think we should need On Tue, Jun 16, 2015 at 3:00 PM, Sean Patrick Santos <
Jim Edwards CESM Software Engineer |
|
Yep, that's the idea. |
|
Is this compatible with #28 ? |
|
I believe so. I rebased the one on top of the other, on the branch where I am working on hobart. |
Merged
jedwards4b
added a commit
to jedwards4b/cime
that referenced
this pull request
Jan 15, 2016
Fixes to get the nightly tests to run through on Caldera with serial MPI
gold2718
pushed a commit
to gold2718/cime
that referenced
this pull request
Oct 19, 2023
…OM_highres Feature blom highres
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were the changes that I needed to be able to get the unit tests to build and pass with NAG on my CGD desktop. Note two possible sources of breakage:
-kind=byteflag. I don't think that this is a big problem because goldbach is being decommissioned this week. When we add a port to the successor machine, we'll have to make sure to link to the appropriate library, and everything should be well again. We should also bump to NAG 6.0. (I don't know if ISG even plans to keep NAG 5.3.1 around, but regardless, I don't think there's any real reason for us to support the older version given that this is our testing compiler.)$NETCDFas a hint for the netCDF directory, which I think is pretty safe, and looking for libcurl if netCDF is using DAP, which may or may not be a problem.