Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apkg rpm build #1627

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Fix apkg rpm build #1627

merged 1 commit into from
Aug 15, 2024

Conversation

qupfer
Copy link
Contributor

@qupfer qupfer commented Aug 14, 2024

On Almalinux9 (and probably other RHEL9 like systems) the "apkg build" packaging step for RPMs seems broken.

I'm not sure, what realy happen but some suggestions.

The cmake file install/copies a file with the line
install(FILES "${CMAKE_SOURCE_DIR}/pam/netopeer2.conf" DESTINATION "${CMAKE_INSTALL_SYSCONFDIR}/pam.d")

CMAKE_INSTALL_SYSCONFDIR is set to "etc" by default, what looks to be correct.

However, maybe related to cmake GNUInstallDirs and and a set/default CMAKE_INSTALL_PREFIX it's expanded internal to /usr/etc, resulting the file mentioned above is put to .../usr/etc/pam.d/

The RPM Spec file on the other side, expect it in %{_sysconfdir} aka /etc and fails.
A solution is to set CMAKE_INSTALL_SYSCONFDIR to the absolut path /etc.

Thats what this MR did. :-)

@qupfer qupfer changed the base branch from master to devel August 14, 2024 16:31
@michalvasko michalvasko merged commit 98cbfa3 into CESNET:devel Aug 15, 2024
5 of 7 checks passed
@michalvasko
Copy link
Member

Thanks, since I cannot think of a better fix, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants