Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: make the CLI prompt configurable #1684

Merged
merged 1 commit into from
Dec 19, 2024
Merged

cli: make the CLI prompt configurable #1684

merged 1 commit into from
Dec 19, 2024

Conversation

hthiery
Copy link
Contributor

@hthiery hthiery commented Dec 19, 2024

No description provided.

michalvasko
michalvasko requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@michalvasko michalvasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, if you find it useful for some reason, but please reorganize the files a bit. No reason for there to be more configurable files, so you can just merge cli_version.h.in and cli_prompt.h.in to cli_config.h.in. Also, please call the macro NC_CLI_PROMPT since it is no longer local and it was a bad name anyway.

@hthiery
Copy link
Contributor Author

hthiery commented Dec 19, 2024

Okay, if you find it useful for some reason, but please reorganize the files a bit. No reason for there to be more configurable files, so you can just merge cli_version.h.in and cli_prompt.h.in to cli_config.h.in. Also, please call the macro NC_CLI_PROMPT since it is no longer local and it was a bad name anyway.

What do you mean with "call the macro NC_CLI_PROMPT"?

  • Do you mean I should change the cmake config option to NC_CLI_PROMPT?
  • or change the name PROMPT to NC_CLI_PROMPT?

@michalvasko
Copy link
Member

I meant the macro PROMPT to be called NC_CLI_PROMPT. CMake var CLI_PROMPT can stay as it is.

@hthiery hthiery force-pushed the feature/configure-cli-prompt branch from dd97fd4 to ac2481f Compare December 19, 2024 09:29
@michalvasko
Copy link
Member

Seems you have not used the latest devel as the base for the change, please update your branch.

@hthiery
Copy link
Contributor Author

hthiery commented Dec 19, 2024

indeed .. I used master :-/

@hthiery
cli: make the CLI prompt configurable
6257aee 
Create a new cli_config.h.in file that contains the version and the
prompt information.

Rename the PROMPT macro to NC_CLI_PROMPT.

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
@hthiery hthiery force-pushed the feature/configure-cli-prompt branch from ac2481f to 6257aee Compare December 19, 2024 11:00
@michalvasko michalvasko merged commit 18a2e17 into CESNET:devel Dec 19, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvasko michalvasko michalvasko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hthiery @michalvasko