Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Range header support #9

Merged
merged 6 commits into from
Jun 30, 2023
Merged

Conversation

brandonsturgeon
Copy link
Member

@brandonsturgeon brandonsturgeon commented Jun 30, 2023

Garry's Mod's HTTP function is prone to failures if the response body is "too big".

To give us some more options for debugging/improving the addon, this PR allows the read methods to respect a given Range header. This lets users download the data in chunks of their choosing.

These changes are fully backwards compatible, but newer addon versions will provide better performance and more reliability.

@brandonsturgeon brandonsturgeon added the enhancement New feature or request label Jun 30, 2023
@brandonsturgeon brandonsturgeon self-assigned this Jun 30, 2023
@brandonsturgeon brandonsturgeon merged commit 4277dc1 into main Jun 30, 2023
@brandonsturgeon brandonsturgeon deleted the feature/add-range-support branch June 30, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant