Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface_mesh::join does not seem to link free elements correcly #3375

Closed
Simon-Lopez opened this issue Oct 5, 2018 · 3 comments
Closed

Surface_mesh::join does not seem to link free elements correcly #3375

Simon-Lopez opened this issue Oct 5, 2018 · 3 comments
Assignees
@sloriot @afabri @Simon-Lopez
Labels
Bug Pkg::Surface_mesh
Milestone
4.12.2

Comments

@Simon-Lopez
Copy link
Contributor

Issue Details

When chaining free elements (vertices, faces and edges) in Surface_mesh::join method the role of self and other seem to be inverted.

Environment

  • CGAL version: latest
@Simon-Lopez Simon-Lopez mentioned this issue Oct 5, 2018
Closed
@Simon-Lopez
Copy link
Contributor Author

The problem does not come from chaining but probably to adding something to the maximum numeric value that gives a smaller size_type object.

Simon-Lopez added a commit to Simon-Lopez/cgal that referenced this issue Oct 5, 2018
@Simon-Lopez
Proposal to fix issue CGAL#3375
23e919c
@Simon-Lopez
Copy link
Contributor Author

The problem comes from the first part of the join method that adds an offset to all of the element imported from the other Surface_mesh object (the one that is joined into the current one), This offset invalidate the chain of freed elements.

@Simon-Lopez Simon-Lopez mentioned this issue Oct 5, 2018
Merged
@lrineau lrineau added this to the 4.14-beta milestone Oct 8, 2018
lrineau pushed a commit to lrineau/cgal that referenced this issue Oct 10, 2018
@Simon-Lopez @lrineau
Proposal to fix issue CGAL#3375
3622f1c
lrineau added a commit that referenced this issue Oct 29, 2018
@lrineau
Merge pull request #3377 from Simon-Lopez/simon_cgal_#3375
8dc7ede 
Proposal to fix issue #3375
lrineau added a commit that referenced this issue Oct 29, 2018
@lrineau
Merge pull request #3377 from Simon-Lopez/simon_cgal_#3375
3c6538f 
Proposal to fix issue #3375
lrineau added a commit that referenced this issue Oct 29, 2018
@lrineau
Merge pull request #3377 from Simon-Lopez/simon_cgal_#3375
fb7dc49 
Proposal to fix issue #3375
@lrineau lrineau modified the milestones: 4.14-beta, 4.12.2 Oct 29, 2018
@lrineau
Copy link
Member

lrineau commented Oct 29, 2018

Fixed by #3377. Will by in CGAL-4.12.2 and CGAL-4.13.1.

@lrineau lrineau closed this as completed Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sloriot sloriot

@afabri afabri

@Simon-Lopez Simon-Lopez

Labels
Bug Pkg::Surface_mesh
Projects
None yet
Milestone
4.12.2
Development

Successfully merging a pull request may close this issue.

Proposal to fix issue #3375
4 participants
@sloriot @afabri @lrineau @Simon-Lopez