Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distance_3: Add Pl_3-Pl_3 #4311

Merged
merged 2 commits into from
Nov 6, 2019
Merged

Distance_3: Add Pl_3-Pl_3 #4311

merged 2 commits into from
Nov 6, 2019

Conversation

maxGimeno
Copy link
Contributor

Summary of Changes

The squared_distance(Plane_3, Plane_3) implementation was missing

Release Management

  • Affected package(s):Distance_3

@maxGimeno maxGimeno added this to the 4.14.2 milestone Oct 24, 2019
@maxGimeno maxGimeno requested a review from sloriot October 24, 2019 14:05
@maxGimeno maxGimeno self-assigned this Oct 24, 2019
sloriot
sloriot reviewed Oct 25, 2019
View reviewed changes
@maxGimeno
Copy link
Contributor Author

Successfully tested in https://cgal.geometryfactory.com/CGAL/testsuite/results-5.0-Ic-183.shtml

@lrineau lrineau added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch labels Nov 6, 2019
lrineau added a commit that referenced this pull request Nov 6, 2019
@lrineau
Merge pull request #4311 from maxGimeno/Distance_3-Plane_plane-maxGimeno
19efe6e 
Distance_3: Add Pl_3-Pl_3
lrineau added a commit that referenced this pull request Nov 6, 2019
@lrineau
Merge pull request #4311 from maxGimeno/Distance_3-Plane_plane-maxGimeno
97ba3ec 
Distance_3: Add Pl_3-Pl_3
@lrineau lrineau merged commit 8251bb9 into CGAL:releases/CGAL-4.14-branch Nov 6, 2019
@lrineau lrineau removed Under Testing rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch labels Nov 6, 2019
@lrineau lrineau deleted the Distance_3-Plane_plane-maxGimeno branch November 6, 2019 17:02
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloriot sloriot sloriot left review comments

Assignees

@maxGimeno maxGimeno

Labels
Bug Merged_in_4.14.2 Merged_in_4.14.3 Merged_in_5.0 Pkg::Distance_3 tested manually on Linux Tested
Projects
None yet
Milestone
4.14.2
Development

Successfully merging this pull request may close these issues.
4 participants
@maxGimeno @sloriot @MaelRL @lrineau