Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locate_with_AABB_tree(Point, ..._) with default point pmap #5122

Conversation

lrineau
Copy link
Member

@lrineau lrineau commented Oct 27, 2020

Summary of Changes

Fix locate_with_AABB_tree(Point, ..._) with default point pmap (CGAL::Default). The compilation error was:

.../Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/locate.h:1697:55: error: no type
      named 'value_type' in 'boost::property_traits<CGAL::Default>'
  typedef typename boost::property_traits<Point3VPM>::value_type                           Point_3;
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~

@MaelRL Probably I should have updated the testsuite, to test that possibility. But the testsuite uses complicated vertex point pmaps. I do not know how to test with CGAL::Default as the pmap. Maybe in the example?

Release Management

@lrineau lrineau added this to the 5.0.4 milestone Oct 27, 2020
@lrineau lrineau requested a review from MaelRL October 27, 2020 09:59
@lrineau lrineau self-assigned this Oct 27, 2020
@maxGimeno
Copy link
Contributor

@lrineau lrineau added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch labels Oct 29, 2020
lrineau added a commit that referenced this pull request Oct 29, 2020
…point-GF

Fix locate_with_AABB_tree(Point, ..._) with default point pmap
@lrineau lrineau merged commit 8151b98 into CGAL:releases/CGAL-5.0-branch Oct 29, 2020
lrineau added a commit that referenced this pull request Oct 29, 2020
…point-GF

Fix locate_with_AABB_tree(Point, ..._) with default point pmap
@lrineau lrineau removed Ready to be tested Under Testing rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' labels Oct 29, 2020
@lrineau lrineau deleted the PMP-fix_locate_with_AABB_tree__point-GF branch October 29, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants