Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add function to refine a mesh along an isocurve #5895

Merged
merged 15 commits into from
Dec 11, 2023
Merged

add function to refine a mesh along an isocurve #5895

merged 15 commits into from
Dec 11, 2023

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented Aug 9, 2021 •
edited
Loading

Add a function in PMP to refine a mesh along an isolevel curve.

Release Management

Todo

  • Add to changes.md
  • Move out of experimental namespace
  • Add to packagedescription.txt
  • Add test for input edges that get constrained

@sloriot sloriot added Pkg::PMP Not yet approved The feature or pull-request has not yet been approved. TODO labels Aug 9, 2021
@sloriot sloriot mentioned this pull request Aug 9, 2021
Closed
@lrineau lrineau added this to the 5.4-beta milestone Aug 10, 2021
@petrasvestartas
Copy link

Can 5.4-beta can be downloaded or I will need to wait until it will be finished?

@lrineau
Copy link
Member

lrineau commented Aug 14, 2021

Can 5.4-beta can be downloaded or I will need to wait until it will be finished?

CGAL-5.4-beta1 is planned for early November 2021. Until then, you can checkout the Git repository (see instructions at https://github.com/CGAL/cgal) or download a zip file of it at https://github.com/CGAL/cgal/archive/refs/heads/master.zip.

@sloriot
Copy link
Member Author

sloriot commented Sep 28, 2021

Successfully tested in CGAL-5.4-Ic-60

@lrineau
Copy link
Member

lrineau commented Sep 29, 2021

@sloriot You are the author of this PR, and you marked it with TODO and not yet approved. And yet, you tested it and marked it Tested. Should I merge it now, or delay the merge until... I do not know.

@sloriot sloriot force-pushed the PMP-refine_mesh_along_isolevel branch from 0cb88ed to 39e1c96 Compare October 7, 2021 13:42
@sloriot sloriot modified the milestones: 5.4-beta, 5.5-beta1 Oct 7, 2021
@MaelRL MaelRL removed the Tested label Nov 4, 2021
@janetournois
Copy link
Member

I have some code that could complement this PR, and will try to add it here asap

@MaelRL MaelRL modified the milestones: 5.5-beta, 5.6-beta Mar 28, 2022
@MaelRL MaelRL modified the milestones: 5.6-beta, 5.7-beta Mar 23, 2023
@MaelRL MaelRL mentioned this pull request Jul 24, 2023
Closed
@sloriot
Copy link
Member Author

sloriot commented Sep 28, 2023

@janetournois actually have a function on a polyhedral complex and uses the mesh domain for queries. There is also no refinement of the input mesh. It is pretty different API.

@sloriot
Copy link
Member Author

sloriot commented Oct 20, 2023

/force-build:v0

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/5895/v0/Manual/index.html

@sloriot @afabri
doc bugs
fe28c0d 
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
@afabri afabri added pre-approved For pre-approved small features. After 15 days the feature will be accepted. and removed Not yet approved The feature or pull-request has not yet been approved. labels Oct 20, 2023
@afabri
Copy link
Member

afabri commented Oct 20, 2023

/force-build:v0

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/5895/v0/Manual/index.html

@sloriot sloriot added Accepted small feature Under Testing and removed pre-approved For pre-approved small features. After 15 days the feature will be accepted. labels Nov 16, 2023
sloriot and others added 2 commits November 30, 2023 09:25
@sloriot
add missing include
fd37bc3
@sloriot @afabri
wrong header
a207e3a 
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
afabri
afabri reviewed Nov 30, 2023
View reviewed changes
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/refine_mesh_at_isolevel.h Outdated
@@ -17,7 +17,8 @@

#include <CGAL/boost/graph/Euler_operations.h>
#include <CGAL/boost/graph/named_params_helper.h>

#include <unordered_set>
#include <unordered_map>
#include <unordered_map>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include <unordered_map>

@sloriot sloriot force-pushed the PMP-refine_mesh_along_isolevel branch from 6ef3d62 to c7ab2ba Compare November 30, 2023 08:55
@sloriot
Copy link
Member Author

sloriot commented Dec 7, 2023

Successfully tested in CGAL-6.0-Ic-122

@lrineau lrineau self-assigned this Dec 7, 2023
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Dec 7, 2023
@lrineau lrineau merged commit 275c175 into CGAL:master Dec 11, 2023
1 check passed
@lrineau lrineau deleted the PMP-refine_mesh_along_isolevel branch December 11, 2023 13:06
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afabri afabri afabri left review comments

@lrineau lrineau lrineau left review comments

@janetournois janetournois janetournois left review comments

Assignees

@lrineau lrineau

Labels
Accepted small feature Merged_in_6.0 Pkg::PMP Small feature Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.

Mesh Split by Geodesic Distance / Iso Values
6 participants
@sloriot @petrasvestartas @lrineau @janetournois @afabri @MaelRL