Introduce remove_all_elements(Graph) #7439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloriot
reviewed
May 12, 2023
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/repair_degeneracies.h
Show resolved
Hide resolved
And leaves everything else like internal property maps and garbage.
MaelRL
force-pushed
the
PMP-Remove_degen_faces-no-clear-GF
branch
from
55ec70f
to
7a2e541
Compare
MaelRL
added
Not yet approved
sloriot
reviewed
Jun 5, 2023
This comment was marked as outdated.
This comment was marked as outdated.
sloriot
added
Under Testing
Batch_2
|
Successfully tested in CGAL-6.0-Ic-64 |
MaelRL
changed the title
|
This pull-request was previously marked with the label |
|
/build:v0 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7439/v0/Manual/index.html |
sloriot
added
the
pre-approved
|
Successfully tested in CGAL-6.0-Ic-21[56] |
sloriot
added
Accepted small feature
and removed
Not yet approved
|
Ready to be merged |
lrineau
added
the
rm only: ready for master
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Using clear() removes mesh properties, which we might not want to do. The code will still remove everything, but iteratively.
TODO:
Release Management
BGL,Polygon_mesh_processing