Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyhedron demo : Add clip box plugin support for more items #7737

Merged
merged 14 commits into from
Oct 16, 2023
Merged

Polyhedron demo : Add clip box plugin support for more items #7737

merged 14 commits into from
Oct 16, 2023

Conversation

ange-clement
Copy link
Member

@ange-clement ange-clement commented Sep 22, 2023 •
edited
Loading

Summary of Changes

The clip box plugin only set shader uniforms. We can add these uniforms in shaders where they were not added.

Tasks :

  • Add support for Images (no_interpolation_shader)
  • Add support for Tetrahedral meshes
  • Disable tetrahedral clip plane
  • Add option to always show edges when clipping
  • Make clip button behave like a toggle
  • Add reset button on clipping box

Release Management

  • Affected package(s): Polyhedron demo
  • Feature/Small Feature (if any):
  • License and copyright ownership:

@ange-clement
Copy link
Member Author

Clip box working on image :
image_clipping

@ange-clement
Copy link
Member Author

Clip box on triangulation 3 mesh
triangulation_3_clipping

@ange-clement ange-clement marked this pull request as ready for review September 26, 2023 08:29
@ange-clement
Copy link
Member Author

Image visualization now draw the surfaces even if they are inside.
This can also be used to visualize a grey-level image.
Images_with_surfaces

@lrineau lrineau added this to the 6.0-beta milestone Sep 26, 2023
@lrineau lrineau added the presentation Used to select pull-requests to include in a branch for a presentation label Oct 5, 2023
@lrineau
fix the random appearance of clip plane
a5d44aa 
For the `Scene_c3t3_item` (and probably `Scene_triangulation_item` as
well) most of the time the clip plane was not shown. This is because of
Boolean data member `cut_plane_enabled` that was not initialized.
@lrineau lrineau mentioned this pull request Oct 6, 2023
Closed
lrineau added a commit to lrineau/cgal that referenced this pull request Oct 12, 2023
@lrineau
Merge pull request CGAL#7737 from ange-clement/Polyhedron-demo-Clippi…
6f1fa46 
…ng-box-more-support-aclement

Polyhedron demo : Add clip box plugin support for more items
lrineau added a commit to lrineau/cgal that referenced this pull request Oct 12, 2023
@lrineau
Merge pull request CGAL#7737 from ange-clement/Polyhedron-demo-Clippi…
160e78b 
…ng-box-more-support-aclement

Polyhedron demo : Add clip box plugin support for more items
@sloriot
Copy link
Member

sloriot commented Oct 15, 2023

Successfully tested in CGAL-6.0-Ic-84

@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Oct 16, 2023
@lrineau lrineau merged commit 3ec0c7e into CGAL:master Oct 16, 2023
9 checks passed
@lrineau lrineau removed rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' presentation Used to select pull-requests to include in a branch for a presentation labels Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrineau lrineau lrineau left review comments

Assignees

@sloriot sloriot

Labels
Bug CGAL 3D demo Merged_in_6.0 Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@ange-clement @sloriot @lrineau