-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpha wrapping: re-use and resume functionalities #7805
Commits on Aug 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8076e20 - Browse repository at this point
Copy the full SHA 8076e20View commit details -
Simplify choice of cells to un-carve while enforcing manifoldness
This combinatorial choice seemed like a good idea, but it can have nasty cascading effects, adding very large tetrahedra. See this issue: CGAL#7625 In the end, the only thing we care about is small volumes being added. I keep the artificial vertex for now, but I am not fully convinced these should be actually kept too.
Configuration menu - View commit details
-
Copy full SHA for c7b9317 - Browse repository at this point
Copy the full SHA c7b9317View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4e207a - Browse repository at this point
Copy the full SHA b4e207aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 330ff2e - Browse repository at this point
Copy the full SHA 330ff2eView commit details
Commits on Sep 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 88bcd40 - Browse repository at this point
Copy the full SHA 88bcd40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4512b0e - Browse repository at this point
Copy the full SHA 4512b0eView commit details -
Consider all cases in facet_status
In a normal run of the algorithm, we shall never ask the facet status of a facet that is already outside, but it's better to be complete and it costs nothing.
Configuration menu - View commit details
-
Copy full SHA for 4d50ec4 - Browse repository at this point
Copy the full SHA 4d50ec4View commit details -
Simplify the gate comparer: we can also sort artificial facets like n…
…ormal facets Artificial facets are *not* infinite facets.
Configuration menu - View commit details
-
Copy full SHA for bff07b2 - Browse repository at this point
Copy the full SHA bff07b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5304f73 - Browse repository at this point
Copy the full SHA 5304f73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3601733 - Browse repository at this point
Copy the full SHA 3601733View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19cb693 - Browse repository at this point
Copy the full SHA 19cb693View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3b6603 - Browse repository at this point
Copy the full SHA d3b6603View commit details
Commits on Sep 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c82f2a9 - Browse repository at this point
Copy the full SHA c82f2a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62bb2a5 - Browse repository at this point
Copy the full SHA 62bb2a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc8351f - Browse repository at this point
Copy the full SHA bc8351fView commit details
Commits on Sep 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 00f167a - Browse repository at this point
Copy the full SHA 00f167aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53c8947 - Browse repository at this point
Copy the full SHA 53c8947View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3854f6 - Browse repository at this point
Copy the full SHA e3854f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfae913 - Browse repository at this point
Copy the full SHA cfae913View commit details -
Use the real circumradius value to sort the facets
Meaning, use the value that we compare against alpha, and not simply the radius of the smallest circumscribing ball. This strongly changes the order of the queue and thus thus results are very different, but still the same (same guarantees, same element quality, only a little bit more elements, etc.) Also a massive, ~35% speed-up, that needs to be investigated.
Configuration menu - View commit details
-
Copy full SHA for 7e2386f - Browse repository at this point
Copy the full SHA 7e2386fView commit details -
Configuration menu - View commit details
-
Copy full SHA for be42e0f - Browse repository at this point
Copy the full SHA be42e0fView commit details -
This doesn't bring any speed-up because it was a very fast exit in push_facet(): the neighbor was necessarily outside (since we come from it), and we are done.
Configuration menu - View commit details
-
Copy full SHA for 8ccce4c - Browse repository at this point
Copy the full SHA 8ccce4cView commit details
Commits on Oct 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c178413 - Browse repository at this point
Copy the full SHA c178413View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fa445f - Browse repository at this point
Copy the full SHA 9fa445fView commit details
Commits on Oct 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ad5ae27 - Browse repository at this point
Copy the full SHA ad5ae27View commit details -
Accelerate trees manually to avoid skewing timers in flood_fill()
If one day this becomes annoying because one wishes to call oracle.add_XXX() multiple times AND it's a significant runtime burden, we can just add a function add_XXXs() with a single call of accelerate_distance_queries()
Configuration menu - View commit details
-
Copy full SHA for 660d620 - Browse repository at this point
Copy the full SHA 660d620View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8846876 - Browse repository at this point
Copy the full SHA 8846876View commit details
Commits on Oct 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 85c53f2 - Browse repository at this point
Copy the full SHA 85c53f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ff06d5 - Browse repository at this point
Copy the full SHA 3ff06d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76add80 - Browse repository at this point
Copy the full SHA 76add80View commit details
Commits on Oct 9, 2023
-
Remove obsolete sort at every iteration
There was a need for sorting at every iteration when the sorting used criteria which were changing with every iteration. This is no longer the case after c7b9317. Also make it deterministic.
Configuration menu - View commit details
-
Copy full SHA for 7de4f44 - Browse repository at this point
Copy the full SHA 7de4f44View commit details -
But keep the old one, because we might need something sorted in the future. Also it is needed to do interrupting, because the intermediate is really ugly for a LIFO queue.
Configuration menu - View commit details
-
Copy full SHA for 2f1992f - Browse repository at this point
Copy the full SHA 2f1992fView commit details
Commits on Oct 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0e9da7a - Browse repository at this point
Copy the full SHA 0e9da7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48d2057 - Browse repository at this point
Copy the full SHA 48d2057View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49f26ab - Browse repository at this point
Copy the full SHA 49f26abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 67e1b32 - Browse repository at this point
Copy the full SHA 67e1b32View commit details -
So it doesn't purge zombies or print gate info that would not be refined
Configuration menu - View commit details
-
Copy full SHA for c19799a - Browse repository at this point
Copy the full SHA c19799aView commit details -
Merge remote-tracking branch 'mine/AW3-Improve_manifoldness_enforceme…
…nt-GF' into AW3-Resume_aw3-GF
Configuration menu - View commit details
-
Copy full SHA for 0600536 - Browse repository at this point
Copy the full SHA 0600536View commit details
Commits on Oct 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e031169 - Browse repository at this point
Copy the full SHA e031169View commit details -
Only flag outside cells during manifold enforcement
Otherwise, it creates holes if we reset manifold flags...
Configuration menu - View commit details
-
Copy full SHA for 1066a96 - Browse repository at this point
Copy the full SHA 1066a96View commit details
Commits on Oct 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3182589 - Browse repository at this point
Copy the full SHA 3182589View commit details -
Configuration menu - View commit details
-
Copy full SHA for 205fcff - Browse repository at this point
Copy the full SHA 205fcffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91c6792 - Browse repository at this point
Copy the full SHA 91c6792View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76aeec9 - Browse repository at this point
Copy the full SHA 76aeec9View commit details
Commits on Oct 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8f3cc5c - Browse repository at this point
Copy the full SHA 8f3cc5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f43c4ec - Browse repository at this point
Copy the full SHA f43c4ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for da6b202 - Browse repository at this point
Copy the full SHA da6b202View commit details -
Revert to the previous non-manifold extraction code
Neither are able to produce a closed, combinatorial manifold surface 100% of the time, so minimize the diff.
Configuration menu - View commit details
-
Copy full SHA for c19975b - Browse repository at this point
Copy the full SHA c19975bView commit details -
Increment erase counter for cells changing labels during flooding
Makes it easier to detect faces that no longer need to be treated (zombies).
Configuration menu - View commit details
-
Copy full SHA for 2984657 - Browse repository at this point
Copy the full SHA 2984657View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f409f0 - Browse repository at this point
Copy the full SHA 8f409f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00acf4f - Browse repository at this point
Copy the full SHA 00acf4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 116bb2b - Browse repository at this point
Copy the full SHA 116bb2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 18154a7 - Browse repository at this point
Copy the full SHA 18154a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1ffdb0 - Browse repository at this point
Copy the full SHA b1ffdb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 021d1fe - Browse repository at this point
Copy the full SHA 021d1feView commit details
Commits on Oct 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 847795e - Browse repository at this point
Copy the full SHA 847795eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d51d71a - Browse repository at this point
Copy the full SHA d51d71aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f753c89 - Browse repository at this point
Copy the full SHA f753c89View commit details
Commits on Oct 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c7af977 - Browse repository at this point
Copy the full SHA c7af977View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c19ffc - Browse repository at this point
Copy the full SHA 2c19ffcView commit details
Commits on Oct 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 21fddd1 - Browse repository at this point
Copy the full SHA 21fddd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb682fe - Browse repository at this point
Copy the full SHA fb682feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3879b13 - Browse repository at this point
Copy the full SHA 3879b13View commit details
Commits on Oct 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4444fdf - Browse repository at this point
Copy the full SHA 4444fdfView commit details
Commits on Nov 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2363e94 - Browse repository at this point
Copy the full SHA 2363e94View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4f6695 - Browse repository at this point
Copy the full SHA e4f6695View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22c2318 - Browse repository at this point
Copy the full SHA 22c2318View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bc087a - Browse repository at this point
Copy the full SHA 2bc087aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f042f5a - Browse repository at this point
Copy the full SHA f042f5aView commit details
Commits on Nov 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f36693c - Browse repository at this point
Copy the full SHA f36693cView commit details
Commits on Nov 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1dc0ba2 - Browse repository at this point
Copy the full SHA 1dc0ba2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b79189 - Browse repository at this point
Copy the full SHA 7b79189View commit details
Commits on Nov 30, 2023
-
Enable pocket purging by default
Reasoning is: this is what users expect.
Configuration menu - View commit details
-
Copy full SHA for 6ad37cd - Browse repository at this point
Copy the full SHA 6ad37cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for fae9bcd - Browse repository at this point
Copy the full SHA fae9bcdView commit details
Commits on Dec 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 07f2f29 - Browse repository at this point
Copy the full SHA 07f2f29View commit details
Commits on Dec 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 20b9952 - Browse repository at this point
Copy the full SHA 20b9952View commit details