Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha wrapping: re-use and resume functionalities #7805

Merged
merged 76 commits into from
Dec 11, 2023

Commits on Aug 3, 2023

  1. Add debug code

    MaelRL committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    8076e20 View commit details
    Browse the repository at this point in the history
  2. Simplify choice of cells to un-carve while enforcing manifoldness

    This combinatorial choice seemed like a good idea, but it can have
    nasty cascading effects, adding very large tetrahedra. See this
    issue: CGAL#7625
    
    In the end, the only thing we care about is small volumes being added.
    
    I keep the artificial vertex for now, but I am not fully convinced
    these should be actually kept too.
    MaelRL committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    c7b9317 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b4e207a View commit details
    Browse the repository at this point in the history
  4. Fix spelling

    MaelRL committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    330ff2e View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Configuration menu
    Copy the full SHA
    88bcd40 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4512b0e View commit details
    Browse the repository at this point in the history
  3. Consider all cases in facet_status

    In a normal run of the algorithm, we shall never ask the facet status
    of a facet that is already outside, but it's better to be complete
    and it costs nothing.
    MaelRL committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    4d50ec4 View commit details
    Browse the repository at this point in the history
  4. Simplify the gate comparer: we can also sort artificial facets like n…

    …ormal facets
    
    Artificial facets are *not* infinite facets.
    MaelRL committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    bff07b2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5304f73 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3601733 View commit details
    Browse the repository at this point in the history
  7. Improve debug code

    MaelRL committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    19cb693 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d3b6603 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Configuration menu
    Copy the full SHA
    c82f2a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    62bb2a5 View commit details
    Browse the repository at this point in the history
  3. Fix typo

    MaelRL authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    bc8351f View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Add benchmarking scripts

    MaelRL committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    00f167a View commit details
    Browse the repository at this point in the history
  2. Rename a variable

    MaelRL committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    53c8947 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e3854f6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cfae913 View commit details
    Browse the repository at this point in the history
  5. Use the real circumradius value to sort the facets

    Meaning, use the value that we compare against alpha, and not
    simply the radius of the smallest circumscribing ball.
    
    This strongly changes the order of the queue and thus thus results
    are very different, but still the same (same guarantees, same
    element quality, only a little bit more elements, etc.)
    
    Also a massive, ~35% speed-up, that needs to be investigated.
    MaelRL committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    7e2386f View commit details
    Browse the repository at this point in the history
  6. Minor debug code cleaning

    MaelRL committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    be42e0f View commit details
    Browse the repository at this point in the history
  7. Avoid one useless facet check

    This doesn't bring any speed-up because it was a very fast exit
    in push_facet(): the neighbor was necessarily outside (since we
    come from it), and we are done.
    MaelRL committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    8ccce4c View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Minor error message tweak

    MaelRL committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    c178413 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9fa445f View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Configuration menu
    Copy the full SHA
    ad5ae27 View commit details
    Browse the repository at this point in the history
  2. Accelerate trees manually to avoid skewing timers in flood_fill()

    If one day this becomes annoying because one wishes to call
    oracle.add_XXX() multiple times AND it's a significant
    runtime burden, we can just add a function add_XXXs()
    with a single call of accelerate_distance_queries()
    MaelRL committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    660d620 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8846876 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Configuration menu
    Copy the full SHA
    85c53f2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3ff06d5 View commit details
    Browse the repository at this point in the history
  3. Add debug code

    MaelRL committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    76add80 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Remove obsolete sort at every iteration

    There was a need for sorting at every iteration when the sorting
    used criteria which were changing with every iteration. This
    is no longer the case after c7b9317.
    
    Also make it deterministic.
    MaelRL committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7de4f44 View commit details
    Browse the repository at this point in the history
  2. Add LIFO queue

    But keep the old one, because we might need something sorted in the future.
    
    Also it is needed to do interrupting, because the intermediate is really
    ugly for a LIFO queue.
    MaelRL committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2f1992f View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Debug code and minor cleaning

    MaelRL committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    0e9da7a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    48d2057 View commit details
    Browse the repository at this point in the history
  3. enum > enum class

    MaelRL committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    49f26ab View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    67e1b32 View commit details
    Browse the repository at this point in the history
  5. Move "go_further()" check up

    So it doesn't purge zombies or print gate info that would not be refined
    MaelRL committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    c19799a View commit details
    Browse the repository at this point in the history
  6. Merge remote-tracking branch 'mine/AW3-Improve_manifoldness_enforceme…

    …nt-GF' into AW3-Resume_aw3-GF
    MaelRL committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    0600536 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Fix merge issue

    MaelRL committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e031169 View commit details
    Browse the repository at this point in the history
  2. Only flag outside cells during manifold enforcement

    Otherwise, it creates holes if we reset manifold flags...
    MaelRL committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    1066a96 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Configuration menu
    Copy the full SHA
    3182589 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    205fcff View commit details
    Browse the repository at this point in the history
  3. Rename the builder class

    MaelRL committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    91c6792 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    76aeec9 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Configuration menu
    Copy the full SHA
    8f3cc5c View commit details
    Browse the repository at this point in the history
  2. Minor example fix

    MaelRL committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    f43c4ec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    da6b202 View commit details
    Browse the repository at this point in the history
  4. Revert to the previous non-manifold extraction code

    Neither are able to produce a closed, combinatorial manifold surface
    100% of the time, so minimize the diff.
    MaelRL committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    c19975b View commit details
    Browse the repository at this point in the history
  5. Increment erase counter for cells changing labels during flooding

    Makes it easier to detect faces that no longer need
    to be treated (zombies).
    MaelRL committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    2984657 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8f409f0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    00acf4f View commit details
    Browse the repository at this point in the history
  8. Fix shadowing variable

    MaelRL committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    116bb2b View commit details
    Browse the repository at this point in the history
  9. Loop only finite faces in the volume computation

    For outward wrapping
    MaelRL committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    18154a7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b1ffdb0 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    021d1fe View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Configuration menu
    Copy the full SHA
    847795e View commit details
    Browse the repository at this point in the history
  2. Misc minor improvements

    MaelRL committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    d51d71a View commit details
    Browse the repository at this point in the history
  3. Minor compilation fix

    MaelRL committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    f753c89 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Configuration menu
    Copy the full SHA
    c7af977 View commit details
    Browse the repository at this point in the history
  2. Add a warning

    MaelRL committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    2c19ffc View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Configuration menu
    Copy the full SHA
    21fddd1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb682fe View commit details
    Browse the repository at this point in the history
  3. Misc minor improvements

    MaelRL committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3879b13 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Fix compilation

    MaelRL committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    4444fdf View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Do not use "Polygon" typedef

    MaelRL committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    2363e94 View commit details
    Browse the repository at this point in the history
  2. Avoid /!\ in comments

    MaelRL committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    e4f6695 View commit details
    Browse the repository at this point in the history
  3. Add a todo

    MaelRL committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    22c2318 View commit details
    Browse the repository at this point in the history
  4. Fix warnings

    MaelRL committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    2bc087a View commit details
    Browse the repository at this point in the history
  5. Fix initialization warning

    MaelRL committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    f042f5a View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Fix warning

    MaelRL committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f36693c View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Configuration menu
    Copy the full SHA
    1dc0ba2 View commit details
    Browse the repository at this point in the history
  2. Fix bbox initialization

    MaelRL committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    7b79189 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Enable pocket purging by default

    Reasoning is: this is what users expect.
    MaelRL committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    6ad37cd View commit details
    Browse the repository at this point in the history
  2. Add some comments

    MaelRL committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    fae9bcd View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    07f2f29 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Fix typo in benchmarks

    MaelRL committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    20b9952 View commit details
    Browse the repository at this point in the history