Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isotropic remeshing: add example with custom dummy sizing #7873

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Isotropic remeshing: add example with custom dummy sizing #7873

merged 6 commits into from
Dec 11, 2023

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented Nov 20, 2023

Add a sizing interpolating the size along the y-axis and also improve the concept.

Screenshot from 2023-11-20 09-43-26

@sloriot sloriot added this to the 6.0-beta milestone Nov 20, 2023
janetournois
janetournois reviewed Nov 20, 2023
View reviewed changes
Polygon_mesh_processing/doc/Polygon_mesh_processing/Concepts/PMPSizingField.h
/// a function that updates the sizing field value at the vertex `v`.
void update(const vertex_descriptor v,
const PolygonMesh& pmesh);
/// function called after the addition of the split vertex `v` in `pmesh`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we mention that the sizing field at v may have to be updated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sizing field class does register it and does what it needs to do. Uniform_sizing is not using it and neither does the custom example. Something like, "can be used to updated pre-computed sizing" can be added if you want to insist on that point.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think that it is important to say it. If there is nothing to update, then it's easy. Otherwise it's good to know that it is here that the user should do it.

@lrineau lrineau changed the title Add example with custom dummy sizing Isotropic remeshing: add example with custom dummy sizing Nov 24, 2023
@sloriot sloriot added Batch_1 First Batch of PRs under testing Under Testing and removed Batch_1 First Batch of PRs under testing labels Nov 28, 2023
@sloriot
Copy link
Member Author

sloriot commented Dec 7, 2023

Successfully tested in CGAL-6.0-Ic-122

@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Dec 7, 2023
@lrineau lrineau self-assigned this Dec 7, 2023
@lrineau lrineau added Under discussion and removed rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' labels Dec 7, 2023
@lrineau
Copy link
Member

lrineau commented Dec 7, 2023 •
edited
Loading

This PR was successfully tested, but there are two unresolved discussions:

For the moment, I will not merge this PR. I let you go on with the discussions.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@github-actions github-actions bot removed the Tested label Dec 7, 2023
@sloriot
Copy link
Member Author

sloriot commented Dec 7, 2023

I fixed both requests that are doc only in doc only files. Local doc testsuite is fine with the changes. Restoring "Tested" flag.

@sloriot sloriot added the Tested label Dec 7, 2023
@lrineau
Copy link
Member

lrineau commented Dec 7, 2023

/build:v2

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7873/v2/Manual/index.html

@sloriot @janetournois
typo
9695579 
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
@github-actions github-actions bot removed the Tested label Dec 7, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@sloriot sloriot added the Tested label Dec 7, 2023
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Dec 7, 2023
@lrineau lrineau merged commit 721487f into CGAL:master Dec 11, 2023
9 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Dec 11, 2023
@lrineau lrineau deleted the PMP-improve_sizing_concept_and_new_ex branch December 11, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albert-github albert-github albert-github left review comments

@janetournois janetournois janetournois left review comments

@ipadjen ipadjen Awaiting requested review from ipadjen

Assignees

@lrineau lrineau

Labels
Cleaning Enhancement Merged_in_6.0 Pkg::PMP Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@sloriot @lrineau @albert-github @janetournois