Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image_IO: sprintf -> snprintf #7961

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Image_IO: sprintf -> snprintf #7961

merged 2 commits into from
Jan 11, 2024

Conversation

afabri
Copy link
Member

@afabri afabri commented Jan 4, 2024

Summary of Changes

sprintf() is deprecated so we replace it with snprintf().

Release Management

  • Affected package(s): CGAL_Image_IO
  • Issue(s) solved (if any): fix warnings in the testsuite for example for Tetrahedral Remeshing

@afabri afabri added Warnings For an issue about warnings, or a pull-request that fixes warnings Ready to be tested Pkg::CGAL_ImageIO labels Jan 4, 2024
@afabri afabri added this to the 6.0-beta milestone Jan 4, 2024
@afabri afabri requested a review from sloriot January 4, 2024 09:22
@sloriot
Copy link
Member

sloriot commented Jan 11, 2024

Successfully tested in CGAL-6.0-Ic-147

@lrineau lrineau self-assigned this Jan 11, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jan 11, 2024
@lrineau lrineau merged commit 83ec3af into CGAL:master Jan 11, 2024
9 checks passed
@lrineau lrineau deleted the CGAL-snprintf-GF branch January 11, 2024 12:00
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloriot sloriot Awaiting requested review from sloriot

Assignees

@lrineau lrineau

Labels
Merged_in_6.0 Pkg::CGAL_ImageIO Tested Warnings For an issue about warnings, or a pull-request that fixes warnings
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@afabri @sloriot @lrineau