Call 3d static filters from NewKernel_d #8026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloriot
added
Batch_1
|
Successfully tested in CGA-6.0-Ic-173 |
sloriot
added
Tested
Enhancement
and removed
Ready to be tested
Batch_1
lrineau
added
the
rm only: ready for master
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
NewKernel_d already had wrappers so it could call some 2d static filters. I blindly copy-pasted so it could also handle 3d.
IIRC, those static filters were just a proof of concept and could do with more work (I don't think they are used by Epeck_d for instance), but I don't have a lot of time for it, and this simple patch (minimal effort) immediately gave a nice speed-up when building a Delaunay triangulation with
Epick_d<Dimension_tag<3>>(enough that it isn't worth having a special case for 3d using Delaunay_triangulation_3 in my application). I might add the weighted versions in another PR later...The main issue with all those filters is that it isn't clear if the testsuite really tests all the layers, but for now it should be ok since Epeck_d does not use static filters.
Release Management