kd-tree: Deallocate Point pointer vector after build(). #8156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This
vector<const Point_d*> data;
is no longer needed after being `.clear()`ed at the end of `build()`.
This can save a good amount of memory, a `Point_d*` on a 64-bit system
is 8 bytes; almost as large as a typical 3-float `Point_d`.
There's no point keeping its capacity, since any call to `build()`
will efficiently `.reserve()` it anyway.
sloriot
added
Enhancement
Ready to be tested
Pkg::Spatial_searching
Under Testing
Tested
and removed
Ready to be tested
Under Testing
labels
|
Successfully tested in CGAL-6.0-Ic-228 |
lrineau
added
the
rm only: ready for master
lrineau
removed
the
rm only: ready for master
|
Also merged. Thanks @nh2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
is no longer needed after being
.clear()ed at the end ofbuild(). This can save a good amount of memory, aPoint_d*on a 64-bit system is 8 bytes; almost as large as a typical 3-floatPoint_d.There's no point keeping its capacity, since any call to
build()will efficiently.reserve()it anyway.Please use the following template to help us managing pull requests.
Summary of Changes
Describe what your pull request changes to CGAL (this can be skipped if it solves an issue already in the tracker or if it is a Feature or Small Feature submitted to the CGAL Wiki).
Release Management