Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake_minimum_required(VERSION 3.12...3.29) #8263

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

lrineau
Copy link
Member

@lrineau lrineau commented Jun 6, 2024

Summary of Changes

Change all cmake_minimum_required to

cmake_minimum_required(VERSION 3.12...3.29)

Release Management

  • Affected package(s): all

@lrineau lrineau added this to the 6.0-beta milestone Jun 6, 2024
@lrineau lrineau added the rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge label Jun 6, 2024
@lrineau
Copy link
Member Author

lrineau commented Jun 6, 2024

This PR is a blocker for CGAL-6.0-beta1, because it impacts downstream packages.

@lrineau
Copy link
Member Author

lrineau commented Jun 6, 2024

I have checked with cmake versions 3.12, 3.18, 3.19, and 3.29 (thanks to Fedora toolbox and a setup script).

@lrineau
Copy link
Member Author

lrineau commented Jun 6, 2024

That does not work with cmake-3.11, and I do not really understand why.

With cmake -DWITH_tests=ON, the error is:

-- Configuring test in test/Installation
CMake Warning (dev) at Installation/cmake/modules/CGAL_add_test.cmake:176 (if):
  Policy CMP0064 is not set: Support new TEST if() operator.  Run "cmake
  --help-policy CMP0064" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  TEST will be interpreted as an operator when the policy is set to NEW.
  Since the policy is not set the OLD behavior will be used.
Call Stack (most recent call first):
  Installation/cmake/modules/CGAL_add_test.cmake:357 (cgal_setup_test_properties)
  Installation/test/Installation/CMakeLists.txt:13 (CGAL_add_test)
  Installation/test/Installation/CMakeLists.txt:39 (create_link_to_program)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Error at Installation/cmake/modules/CGAL_add_test.cmake:176 (if):
  if given arguments:

    "NOT" "TEST" "copy source_dir of Installation_Tests"

  Unknown arguments specified
Call Stack (most recent call first):
  Installation/cmake/modules/CGAL_add_test.cmake:357 (cgal_setup_test_properties)
  Installation/test/Installation/CMakeLists.txt:13 (CGAL_add_test)
  Installation/test/Installation/CMakeLists.txt:39 (create_link_to_program)


-- Configuring incomplete, errors occurred!

@sloriot
Copy link
Member

sloriot commented Jun 12, 2024

Successfully tested in CGAL-6.0-Ic-264

@lrineau lrineau self-assigned this Jun 12, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 12, 2024
@lrineau lrineau merged commit 32893b9 into CGAL:master Jun 12, 2024
8 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 12, 2024
@lrineau lrineau deleted the CGAL-update_minimal_cmake-GF branch June 12, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake scripts Enhancement Merged_in_6.0 rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge Tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants