Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T3/T2/PT: Add namespace to classes in concepts #8283

Merged
merged 1 commit into from
Jul 23, 2024
Merged

T3/T2/PT: Add namespace to classes in concepts #8283

merged 1 commit into from
Jul 23, 2024

Conversation

afabri
Copy link
Member

@afabri afabri commented Jun 12, 2024 •
edited by MaelRL
Loading

Summary of Changes

In order to have links to classes in concepts we have to prefix with the namespace.

Release Management

  • Affected package(s): T3, T2, PT2
  • License and copyright ownership: unchanged

@afabri afabri self-assigned this Jun 12, 2024
@afabri afabri added this to the 5.6.2 milestone Jun 12, 2024
@afabri afabri added the trivial label Jun 12, 2024
@lrineau lrineau changed the base branch from master to 5.6.x-branch June 12, 2024 13:18
@afabri
Copy link
Member Author

afabri commented Jun 12, 2024

CI fails as this PR aims 5.6.2

@MaelRL MaelRL changed the title T3/T2/PT: Add namespace to models in concepts T3/T2/PT: Add namespace to classes in concepts Jun 18, 2024
@sloriot
Copy link
Member

sloriot commented Jul 15, 2024

Successfully tested in CGAL-6.0-Ic-286

@sloriot sloriot merged commit 2ce800a into CGAL:5.6.x-branch Jul 23, 2024
7 of 8 checks passed
@lrineau lrineau deleted the T3-namespace-GF branch September 25, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@afabri afabri

Labels
Cleaning Doc bug known false-positive in CI checks Merged_in_6.0 Tested trivial
Projects
None yet
Milestone
5.6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@afabri @sloriot @lrineau