Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation - update FindOpenMesh.cmake #8332

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Installation - update FindOpenMesh.cmake #8332

merged 6 commits into from
Sep 6, 2024

Conversation

janetournois
Copy link
Member

Summary of Changes

This PR updates CGAL's FindOpenMesh.cmake, accordingly with the one provided by OpenMesh 11.0, and introducing the target OpenMesh::OpenMesh

Release Management

  • Affected package(s): Installation
  • License and copyright ownership: unchanged

@janetournois janetournois changed the title Installation - update FindOpenMesh.cmake Installation - update FindOpenMesh.cmake Jul 3, 2024
@janetournois janetournois added this to the 6.1-beta milestone Jul 3, 2024
@sloriot
Copy link
Member

sloriot commented Jul 4, 2024

Since the target is from CGAL, shouldn't be prefixed with CGAL? Or even CGAL_OpenMesh_support to be consistent?

@sloriot
Copy link
Member

sloriot commented Aug 1, 2024

Successfully tested in CGAL-6.0-Ic-300

@janetournois
Copy link
Member Author

I have unpushed temporary code to add the CGAL prefix as you suggested @sloriot
Do not merge this PR yet

@github-actions github-actions bot removed the Tested label Aug 27, 2024
@github-actions GitHub Actions
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@janetournois
Copy link
Member Author

Christo is up-to-date to test CGAL examples with OpenMesh-11.0

@sloriot sloriot modified the milestones: 6.1-beta, 6.0 Sep 4, 2024
@janetournois janetournois mentioned this pull request Sep 5, 2024
Open
@sloriot
Copy link
Member

sloriot commented Sep 6, 2024

Successfully tested in CGAL-6.0-Ic-321

@sloriot sloriot merged commit abd0a58 into CGAL:master Sep 6, 2024
9 checks passed
@sloriot sloriot deleted the Installation-findOpenMesh-jtournois branch September 6, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CMake scripts Enhancement Merged_in_6.0 Tested
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@janetournois @sloriot @lrineau