Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh_3 - bug fixes for edge_distance and edge_min_size #8405

Merged
merged 9 commits into from
Aug 26, 2024
Merged

Mesh_3 - bug fixes for edge_distance and edge_min_size #8405

merged 9 commits into from
Aug 26, 2024

Commits on Aug 8, 2024

  1. take min_size into account inside Mesh_edge_criteria_3

    @janetournois
    janetournois committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f8de6e7 View commit details
    Browse the repository at this point in the history

  2. use the 5 parameters version to avoid re-calling locate(p) and locate(q)

    @janetournois
    janetournois committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    0bc3658 View commit details
    Browse the repository at this point in the history

  3. improve Mesh_3 log in demo

    @janetournois
    janetournois committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    4d38aa5 View commit details
    Browse the repository at this point in the history

  4. add missing not-nullptr check

    @janetournois
    janetournois committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    fa97ae8 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. fix approx_is_too_large(edge) that needs the corresponding curve_inde… 

    …x to be valid

use minimal_size instead of 0

fix 5e64bce

fix approx_is_too_large(edge) that needs the corresponding curve_index to be valid

and fix the default edge_min_size
    @janetournois
    janetournois committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    fd498e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. weight_modifier was likely to make the weight too small 

    let's keep the minimal weight as given in meshing criteria
    @janetournois
    janetournois committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    14a9db6 View commit details
    Browse the repository at this point in the history

  2. use c++11 for loops

    @janetournois
    janetournois committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    481de41 View commit details
    Browse the repository at this point in the history

  3. ease dump code reading

    @janetournois
    janetournois committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4a35823 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. vertices(edge) is not available in P3T3

    @janetournois
    janetournois committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    93fd7f8 View commit details
    Browse the repository at this point in the history