Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sns fix loading of gtf annotations #408

Merged
merged 2 commits into from
Feb 20, 2018

Conversation

snsansom
Copy link
Member

@snsansom snsansom commented Feb 19, 2018

Can't see why we wouldn't want to parse all the attributes into a separate field? (i.e. cgat gtf2tsv -f). Without the "-f", the gene_id and transcript_id were not being picked up!.

Loading hg38_ensembl91 (after running gtf2csv with the -f option) needs at 13G.
@snsansom snsansom requested a review from Acribbs February 19, 2018 16:08
Copy link
Member

@Acribbs Acribbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! However, I think I may revisit this in the future and see if memory requirements can be reduced.

@sebastian-luna-valero
Copy link
Member

Thanks Steve!

@sebastian-luna-valero sebastian-luna-valero merged commit d0f6d22 into master Feb 20, 2018
@sebastian-luna-valero sebastian-luna-valero deleted the sns_fix_loading_of_gtf_annotations branch February 20, 2018 09:11
@AndreasHeger AndreasHeger added the ApplyToNew Apply this pull request to cgat-developers label Mar 16, 2018
sebastian-luna-valero added a commit to cgat-developers/cgat-flow that referenced this pull request Jun 1, 2018
sebastian-luna-valero added a commit to cgat-developers/cgat-flow that referenced this pull request Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ApplyToNew Apply this pull request to cgat-developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants