-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{ts} barcode extract either read #311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also wonder how hard it would be to allow the user to provide a single regex for both reads.
@IanSudbery - OK for merge? |
How about allowing the user to just provide one regex if it can be on either read? |
Oops, sorry, missed this! We could have a single regex option by simply reusing Personally, I'd rather stick with the current implementation and force the user to be explicit so there's no unexpected behaviour when the regexes are different and they have forgotten to specify |
go ahead and merge this. |
Note, the commits on Jan 24 are from a merge with branch
{TS}-EnablePerCellCountTab
(PR #308). Probably best to merge that PR before reviewing the changes herein.See #175 for motivation
--either-read
.--either-read
I don't have a good input sample for the test so the current input is hacked together from the indrop data (see
tests/README
). Basically swapped read1 and read2 at random and use option to identify which read matches the regex. Of course, the output from this is now garbage. I'll post on #175 and ask for more suitable toy data. Also need to add a test to cover--either-read-resolve=quality