Ts add test action #546
Merged
Ts add test action #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanSudbery
approved these changes
Jul 14, 2022
|
No, was just doing my usual copy/paste/edit/debug and hadn't considered the minimum python version we'd like to test. How low to go?.. |
|
I don't think many people are using 3.5 anymore, but 3.6 is still quite common I think. |
TomSmithCGAT
added a commit
that referenced
this pull request
Feb 27, 2023
Removes 3.10 which is incompatible with nose (nose-devs/nose#1099 & #546)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds github actions to perform testing.
Still relying on the same bespoke test script we repurposed from cgat which utilises
nose. Note thatnoseis no longer supported and cannot be used to test python 3.10 (nose-devs/nose#1099). I tried a few of the suggestions in that issue to resolve the issue but nothing worked straight out of the box.For now, I've dropped testing for
python 3.10in favour of getting the CI testing back up and running. In the long run, it seems like we should be switching topytest.