Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read suffixes removed from single end data #591

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

IanSudbery
Copy link
Member

Moved code to remove "suffixes" from the first word of of the read identifier from joinedFastqIterate to fastqIterate.

Changed call of fastqIterate in extract to specify whether to remove suffixes.

Should solve #580

Moved code to remove "suffixes" from the first word of
of the read identifier from joinedFastqIterate to fastqIterate.

Changed call of fastqIterate in extract to specify  whether
to remove suffixes.
@IanSudbery IanSudbery requested a review from TomSmithCGAT April 11, 2023 10:46
Copy link
Member

@TomSmithCGAT TomSmithCGAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generalises and simplifies 😁

@TomSmithCGAT
Copy link
Member

@IanSudbery - Happy for you to merge if this PR is complete.

@IanSudbery IanSudbery merged commit 9224ca1 into master Apr 11, 2023
@IanSudbery IanSudbery deleted the {IS}_suffixes_for_single_end branch April 11, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants