Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports #355

Merged
merged 4 commits into from
Sep 14, 2017
Merged

Remove unused imports #355

merged 4 commits into from
Sep 14, 2017

Conversation

sebastian-luna-valero
Copy link
Member

@sebastian-luna-valero sebastian-luna-valero commented Sep 4, 2017

Used autoflake to automatically remove unused imports:
https://github.com/myint/autoflake

Commands:

autoflake --remove-all-unused-imports -i -r cgat/CGAT/
autoflake --remove-all-unused-imports -i -r cgat/doc/
autoflake --remove-all-unused-imports -i -r cgat/tests/

This will help to create a (smaller) conda environment for code portability.

@sebastian-luna-valero
Copy link
Member Author

The main goal of this PR was to reduce the number of conda dependencies. However, the total number of dependencies did not decreased at all after refactoring the code.

In addition to that, here is a text from the autoflake page that concerns me:

By default, autoflake only removes unused imports for modules that are part of the standard library. (Other modules may have side effects that make them unsafe to remove automatically.)

Although the tests on travis pass, I have not had time to test the code fully with Jenkins. Therefore, please leave the PR open until I can do that.

@sebastian-luna-valero
Copy link
Member Author

Jenkins tests are currently passing with on this branch, so will merge to master.

@sebastian-luna-valero sebastian-luna-valero merged commit 881eea0 into master Sep 14, 2017
@sebastian-luna-valero sebastian-luna-valero deleted the SLV-unused-imports branch September 14, 2017 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant