Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed annotations in Blender 2.93 #74

Merged
merged 1 commit into from
May 24, 2021
Merged

Conversation

Darkblader24
Copy link
Contributor

This fixes many issues with Blender 2.93, like #70.

Copy link
Collaborator

@TheDuckCow TheDuckCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome you found this way to make annotations still work! That being said, I'm still debating whether this repository should just adopt the blender annotations convention at this point, since the syntax only really impacts pre blender 2.80.

I'll likely approve this in the meantime to unblock blender 2.93, but do you find you are generally still supporting 2.7x addons?

@Darkblader24
Copy link
Contributor Author

If you choose to discontinue support for pre 2.80, you will take the choice away from addon creators who would still like to support it.
I still support 2.7x in plugins that I started back then, but I no longer do that for newer ones.

@TheDuckCow
Copy link
Collaborator

Very true, consider me convinced. I'm in the same boat actually with some addons that I still manage, so this change is saving me from dropping 2.7x users which is great. Just tried and confirm this is working as expected in different addons up through and including even the most recent blender 3.0 builds, merging shortly!

@TheDuckCow TheDuckCow merged commit e0735a7 into CGCookie:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants