Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Unit tests of each dotnet project should be placed on a dedicated folder #1018

Closed
hocinehacherouf opened this issue Aug 2, 2022 · 0 comments · Fixed by #1042
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@hocinehacherouf
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, it is difficult

  • To distinguish unit tests coded in the project AzureIoTHub.Portal.Server.Tests.Unit
  • To identify with which project they are linked/testing

Describe the solution you'd like

Unit tests of each dotnet project should be placed on a dedicated folder.

Example of the layout of the unit test project:

.
└── AzureIoTHub.Portal.Server.Tests.Unit/
    ├── Client/
    │   ├── Components/
    │   │   └── ...
    │   ├── Pages/
    │   │   └── ...
    │   ├── Services/
    │   │   └── ...
    │   └── Shared/
    │       └── ...
    ├── Server/
    │   ├── Controllers/
    │   │   └── ...
    │   ├── Services/
    │   │   └── ...
    │   └── ...
    └── Shared/
        ├── Constants/
        │   └── ...
        ├── Models/
        │   └── ...
        └── ...
@hocinehacherouf hocinehacherouf added enhancement New feature or request refinement labels Aug 2, 2022
@kbeaugrand kbeaugrand added this to the S35 milestone Aug 8, 2022
@kbeaugrand kbeaugrand moved this to :pencil: Todo in IoT Hub Portal Aug 8, 2022
@hocinehacherouf hocinehacherouf moved this from :pencil: Todo to :construction: In Progress in IoT Hub Portal Aug 8, 2022
@hocinehacherouf hocinehacherouf self-assigned this Aug 8, 2022
@hocinehacherouf hocinehacherouf moved this from :construction: In Progress to :speech_balloon: Ready for Review in IoT Hub Portal Aug 8, 2022
hocinehacherouf added a commit that referenced this issue Aug 9, 2022
hocinehacherouf added a commit that referenced this issue Aug 9, 2022
* Rename unit test project #1018

* Rework of unit tests project layout #1018

* Update old unit tests project name in build ci #1018

* Fix conflicts after rebase onto main

* Update dotnet sdk to 6.0.400 #1059 

* Add cast to JProperty on ConfigHelper.GetEnvironmentVariables to fix Roslyn error
@hocinehacherouf hocinehacherouf moved this from :speech_balloon: Ready for Review to :rocket: Ready in IoT Hub Portal Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🚀 Ready
Development

Successfully merging a pull request may close this issue.

2 participants