Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Migrate Helpers to Application Layer #1553

Closed
kbeaugrand opened this issue Nov 17, 2022 · 1 comment · Fixed by #1643
Closed

Task: Migrate Helpers to Application Layer #1553

kbeaugrand opened this issue Nov 17, 2022 · 1 comment · Fixed by #1643
Assignees
@kbeaugrand
Labels
refactoring Restructure the source code so as to improve operation with
Milestone
S49

Comments

@kbeaugrand
Copy link
Member

Story: #1256

Description
Migrate Helpers to Application Layer
@developer-companion developer-companion bot moved this to 📝 Todo in IoT Hub Portal Nov 17, 2022
@kbeaugrand kbeaugrand added the refactoring Restructure the source code so as to improve operation with label Nov 26, 2022
@kbeaugrand kbeaugrand added this to the S49 milestone Dec 5, 2022
@kbeaugrand kbeaugrand self-assigned this Dec 5, 2022
@kbeaugrand kbeaugrand moved this from 📝 Todo to 🚧 In Progress in IoT Hub Portal Dec 6, 2022
@kbeaugrand kbeaugrand moved this from 🚧 In Progress to 💬 Ready for Review in IoT Hub Portal Dec 6, 2022
@kbeaugrand
Copy link
Member Author

kbeaugrand commented Dec 6, 2022 •
edited
Loading

Since helpers are using Microsoft.Azure.Devices package, these classes has been dropped to Infrastructure

-- EDIT

These classes are present in Application layer, we do need reference to Microsoft.Azure.Devices in this layer for the moment

kbeaugrand added a commit that referenced this issue Dec 6, 2022
@kbeaugrand
Fix #1551 + #1553 + #1554 + #1549
e4a9225
@kbeaugrand kbeaugrand mentioned this issue Dec 6, 2022
Merged
9 tasks
hocinehacherouf pushed a commit that referenced this issue Dec 6, 2022
@kbeaugrand
Fix #1256 - Add application layer to the project (#1643)
001194b 
* Fix #1551 + #1553 + #1554 + #1549

* Migrate automapper profiles

* Migrate mappers

* Create LoRaWanManagementService

* Fix #1550
@hocinehacherouf hocinehacherouf moved this from 💬 Ready for Review to 🚀 Ready in IoT Hub Portal Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbeaugrand kbeaugrand

Labels
refactoring Restructure the source code so as to improve operation with
Projects
IoT Hub Portal
Status: 🚀 Ready
Milestone
S49
Development

Successfully merging a pull request may close this issue.

Fix #1256 - Add application layer to the project CGI-FR/IoT-Hub-Portal
1 participant
@kbeaugrand