Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Device list, do not load device model by default, and search the model at backend #1827

Closed
2 tasks
kbeaugrand opened this issue Mar 1, 2023 · 0 comments
Closed
2 tasks
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kbeaugrand
Copy link
Member

kbeaugrand commented Mar 1, 2023

Expected Behavior

When device list page is loading, there is no need to load the device models since there is no filters.
When the user is trying to filter devices by a model, he is able to type the model name and the UI returns available models that match the model name typed...

Current Behavior

During the page initialization, we are looking for the first 10 models and filter it then in the browser. If there are more than 10 models, the user is not able to filter the devices by the model if this is not present in the first bucket.

Steps to Fix

Corrections that should be done:

  • During the page initialization, Model list loading can be removed (by default this is already an empty array.
  • In Search, we should use the search text to query the API and search at the backend. We can return only the page 0 with page size 10.

Context (Environment)

Portal version: 4.5
LoRaWAN Stack version: N/A

Logs

Additional Information

@kbeaugrand kbeaugrand added the bug Something isn't working label Mar 1, 2023
@github-project-automation github-project-automation bot moved this to 📝 Todo in IoT Hub Portal Mar 1, 2023
@kbeaugrand kbeaugrand added this to the S52 milestone Mar 1, 2023
@GuillaumeM-2ISA GuillaumeM-2ISA moved this from 📝 Todo to 🚧 In Progress in IoT Hub Portal Mar 1, 2023
@GuillaumeM-2ISA GuillaumeM-2ISA moved this from 🚧 In Progress to 💬 Ready for Review in IoT Hub Portal Mar 1, 2023
@GuillaumeM-2ISA GuillaumeM-2ISA moved this from 💬 Ready for Review to 🚀 Ready in IoT Hub Portal Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🚀 Ready
Development

No branches or pull requests

2 participants