Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1827 - On search device list, laod device model when filtering on device model only #1833

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

GuillaumeM-2ISA
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (47f392a) 91.27% compared to head (302a421) 91.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1833      +/-   ##
==========================================
- Coverage   91.27%   91.27%   -0.01%     
==========================================
  Files         277      277              
  Lines        9034     9028       -6     
==========================================
- Hits         8246     8240       -6     
  Misses        788      788              
Impacted Files Coverage Δ
...b.Portal.Client/Pages/Devices/DeviceListPage.razor 88.70% <100.00%> (-0.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuillaumeM-2ISA GuillaumeM-2ISA marked this pull request as ready for review March 1, 2023 15:33
@GuillaumeM-2ISA GuillaumeM-2ISA requested a review from a team as a code owner March 1, 2023 15:33
@kbeaugrand kbeaugrand changed the title fix device list page Fix #1827 - On search device list, laod device model when filtering on device model only Mar 1, 2023
@kbeaugrand kbeaugrand merged commit a26c83c into main Mar 1, 2023
@kbeaugrand kbeaugrand deleted the Bugfix/1827_fix_device_model_load_on_devicelist branch March 1, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants