Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Add id for the tags #1901

Closed
Achraf-Git-dev opened this issue Mar 16, 2023 · 1 comment · Fixed by #1917
Closed

Task: Add id for the tags #1901

Achraf-Git-dev opened this issue Mar 16, 2023 · 1 comment · Fixed by #1917
Assignees
@kbeaugrand
Labels
invalid This doesn't seem right
Milestone
The Portal Keeper...

Comments

@Achraf-Git-dev
Copy link
Contributor

Story: #1485

Description
On the tags page, we need a way to identify the different lines in a nominative way (by id for instance) in order to do the E2E tests.
@github-project-automation github-project-automation bot moved this to 📝 Todo in IoT Hub Portal Mar 16, 2023
@kbeaugrand kbeaugrand added refinement invalid This doesn't seem right and removed refinement labels Mar 18, 2023
@kbeaugrand kbeaugrand added this to the The Portal Keepers - S55 milestone Mar 18, 2023
@kbeaugrand kbeaugrand self-assigned this Mar 18, 2023
@kbeaugrand
Copy link
Member

@Achraf-Git-dev I added a class name on each row.
class will have the syntax 'tag-'+ tagName

kbeaugrand added a commit that referenced this issue Mar 18, 2023
@kbeaugrand
Fix #1901 - Add class name in rows to identfy tag in DOM
1e8cb18
@kbeaugrand kbeaugrand mentioned this issue Mar 18, 2023
Merged
9 tasks
kbeaugrand added a commit that referenced this issue Mar 18, 2023
@kbeaugrand
Fix #1901 - Add class name in rows to identfy tag in DOM (#1917)
ee40e2f 
* Fix #1901 - Add class name in rows to identfy tag in DOM

* Fix E2E test
@kbeaugrand kbeaugrand moved this from 📝 Todo to 🚀 Ready in IoT Hub Portal Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbeaugrand kbeaugrand

Labels
invalid This doesn't seem right
Projects
IoT Hub Portal
Status: 🚀 Ready
Milestone
The Portal Keepers - S55
Development

Successfully merging a pull request may close this issue.

Fix #1901 - Add class name in rows to identfy tag in DOM CGI-FR/IoT-Hub-Portal
2 participants
@kbeaugrand @Achraf-Git-dev