Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Incorrect documentation in v4.13.2 on Azure app settings and connection strings #2555

Closed
Metal-Mighty opened this issue Oct 2, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Metal-Mighty
Copy link
Contributor

Metal-Mighty commented Oct 2, 2023

Expected Behavior

A documented list of Azure application settings and connection strings

Current Behavior

The AppSettings and Connection Strings are in two places: The Azure page and the Dev Guide page.

  • The Azure page mixes both AppSettings and Connection Strings without explanation of which is which, and uses parameters with the Azure: prefix, which is not consistent with the code. In my opinion, the json file shouldn't be shown here, it should be the list of settings expected for Azure in a format consistent with how Azure will require them.
  • The settings in the Dev Guide page are inconsistent between the Json file and the explanation of the settings in the following section. Are the settings for Azure even required at this location ? Shouldn't they be only on the Azure page ?

Steps to Reproduce

Head to the doc :)

Context (Environment)

Portal version: 4.13.2
LoRaWAN Stack version:

Logs

Additional Information

https://cgi-fr.github.io/IoT-Hub-Portal/v4.13.2/azure/#configurationssecrets
https://cgi-fr.github.io/IoT-Hub-Portal/v4.13.2/dev-guide/#secrets

@Metal-Mighty Metal-Mighty added the bug Something isn't working label Oct 2, 2023
@github-project-automation github-project-automation bot moved this to 📝 Todo in IoT Hub Portal Oct 2, 2023
TLeoDev pushed a commit that referenced this issue Dec 5, 2023
@TLeoDev TLeoDev moved this from 📝 Todo to 💬 Ready for Review in IoT Hub Portal Dec 6, 2023
kbeaugrand pushed a commit that referenced this issue Dec 6, 2023
Co-authored-by: Léo TUAILLON <leo.tuaillon@cgi.com>
@TLeoDev TLeoDev self-assigned this Dec 6, 2023
@TLeoDev TLeoDev moved this from 💬 Ready for Review to 🚀 Ready in IoT Hub Portal Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🚀 Ready
Development

No branches or pull requests

3 participants