Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Remove unecessary twin desired properties on LoRa Device updates #554

Closed
kbeaugrand opened this issue Apr 6, 2022 · 0 comments · Fixed by #602
Closed

Task: Remove unecessary twin desired properties on LoRa Device updates #554

kbeaugrand opened this issue Apr 6, 2022 · 0 comments · Fixed by #602
Assignees
Labels
bug Something isn't working invalid This doesn't seem right
Milestone

Comments

@kbeaugrand
Copy link
Member

kbeaugrand commented Apr 6, 2022

Expected Behavior

Updating the LoRa device should not update some desire properties.

Current Behavior

LoRaDeviceTwinMapper is updating some desired properties that are supposed to be updated by the model (via a configuration).

Steps to Reproduce

Context (Environment)

Portal version: 1.0.7
LoRaWAN Stack version: N/A

Logs

Additional Information

These properties has been reported on the code by a TODO:
// TODO : Remove if provided by the model

For each property, verify first that the model is creating a configuration with the expected value!

@kbeaugrand kbeaugrand added bug Something isn't working invalid This doesn't seem right labels Apr 6, 2022
@kbeaugrand kbeaugrand added this to the S19 milestone Apr 8, 2022
@kbeaugrand kbeaugrand moved this to :pencil: Todo in IoT Hub Portal Apr 8, 2022
@kbeaugrand kbeaugrand self-assigned this Apr 15, 2022
@kbeaugrand kbeaugrand moved this from :pencil: Todo to :construction: In Progress in IoT Hub Portal Apr 15, 2022
kbeaugrand added a commit that referenced this issue Apr 15, 2022
@kbeaugrand kbeaugrand moved this from :construction: In Progress to :speech_balloon: Ready for Review in IoT Hub Portal Apr 15, 2022
kbeaugrand added a commit that referenced this issue Apr 15, 2022
@kbeaugrand kbeaugrand moved this from :speech_balloon: Ready for Review to :rocket: Ready in IoT Hub Portal Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
Status: 🚀 Ready
Development

Successfully merging a pull request may close this issue.

1 participant