Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Avoid usage of browser cache after updating the image of a device model #763

Closed
5 tasks
hocinehacherouf opened this issue Jun 3, 2022 · 0 comments · Fixed by #1044
Closed
5 tasks

Feature: Avoid usage of browser cache after updating the image of a device model #763

hocinehacherouf opened this issue Jun 3, 2022 · 0 comments · Fixed by #1044
Assignees
@hocinehacherouf
Labels
enhancement New feature or request
Milestone
S35

Comments

@hocinehacherouf
Copy link
Contributor

hocinehacherouf commented Jun 3, 2022 •
edited by kbeaugrand
Loading

Is your feature request related to a problem? Please describe.

After updating the image of a device mode, the image has the same url as the previous image.
Users will see the old image because the browser will still use the cache of this old image.

Describe the solution you'd like

After updating the image of a device mode:

  • The new image must have a new url (different from the url of the old image)
  • The old image must be deleted

Acceptance criterias :

  • Device Models
  • LoRa Device models
  • Edge Device models
@hocinehacherouf hocinehacherouf added enhancement New feature or request refinement labels Jun 3, 2022
@kbeaugrand kbeaugrand added this to the S35 milestone Aug 8, 2022
@kbeaugrand kbeaugrand moved this to :pencil: Todo in IoT Hub Portal Aug 8, 2022
@hocinehacherouf hocinehacherouf moved this from :pencil: Todo to :construction: In Progress in IoT Hub Portal Aug 8, 2022
@hocinehacherouf hocinehacherouf self-assigned this Aug 8, 2022
@hocinehacherouf hocinehacherouf mentioned this issue Aug 9, 2022
Merged
9 tasks
@hocinehacherouf hocinehacherouf moved this from :construction: In Progress to :speech_balloon: Ready for Review in IoT Hub Portal Aug 9, 2022
hocinehacherouf added a commit that referenced this issue Aug 9, 2022
@hocinehacherouf
Add unit test on ChangeDeviceModelImageAsync #763
4bc5f39
hocinehacherouf added a commit that referenced this issue Aug 9, 2022
@hocinehacherouf
Add SyncImagesCacheControl #763
1c94725
hocinehacherouf added a commit that referenced this issue Aug 9, 2022
@hocinehacherouf
Add unit test on SyncImagesCacheControl #763
8562a95
hocinehacherouf added a commit that referenced this issue Aug 9, 2022
@hocinehacherouf
Add StorageAccountDeviceModelImageMaxAge config #763
48e3ad5
hocinehacherouf added a commit that referenced this issue Aug 9, 2022
@hocinehacherouf
Add Cache Control when uploading devices models images (#1044)
daca354 
* Add unit test on ChangeDeviceModelImageAsync #763

* Add SyncImagesCacheControl #763

* Add unit test on SyncImagesCacheControl #763

* Add StorageAccountDeviceModelImageMaxAge config #763

* Remove unused variable
@hocinehacherouf hocinehacherouf moved this from :speech_balloon: Ready for Review to :rocket: Ready in IoT Hub Portal Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hocinehacherouf hocinehacherouf

Labels
enhancement New feature or request
Projects
IoT Hub Portal
Status: 🚀 Ready
Milestone
S35
Development

Successfully merging a pull request may close this issue.

Add Cache Control when uploading devices models images CGI-FR/IoT-Hub-Portal
2 participants
@kbeaugrand @hocinehacherouf