Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/975 fix refresh on pagination #1005

Merged
merged 4 commits into from
Aug 1, 2022

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #1005 (3090879) into main (8996455) will increase coverage by 0.17%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
+ Coverage   84.93%   85.11%   +0.17%     
==========================================
  Files         175      175              
  Lines        5794     5803       +9     
==========================================
+ Hits         4921     4939      +18     
+ Misses        873      864       -9     
Impacted Files Coverage Δ
...es/LoRaWAN/Concentrator/ConcentratorListPage.razor 70.49% <88.88%> (+6.69%) ⬆️
...b.Portal/Client/Pages/Devices/DeviceListPage.razor 72.27% <100.00%> (+3.90%) ⬆️
.../Client/Pages/EdgeDevices/EdgeDeviceListPage.razor 72.85% <100.00%> (+5.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8996455...3090879. Read the comment docs.

@hocinehacherouf hocinehacherouf marked this pull request as ready for review August 1, 2022 09:51
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner August 1, 2022 09:51
@kbeaugrand kbeaugrand force-pushed the bugfix/975_fix_refresh_on_pagination branch from a9064d9 to 3090879 Compare August 1, 2022 15:19
@kbeaugrand kbeaugrand enabled auto-merge (squash) August 1, 2022 15:19
@kbeaugrand kbeaugrand merged commit 28dac51 into main Aug 1, 2022
@kbeaugrand kbeaugrand deleted the bugfix/975_fix_refresh_on_pagination branch August 1, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Clicking on reload button breaks paginations of tables
2 participants