Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/907 alway send confirmed property on command #1037

Merged

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #1037 (3abdd9d) into main (72436d5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1037      +/-   ##
==========================================
- Coverage   85.26%   85.24%   -0.02%     
==========================================
  Files         177      177              
  Lines        5816     5810       -6     
==========================================
- Hits         4959     4953       -6     
  Misses        857      857              
Impacted Files Coverage Δ
....Portal/Server/Managers/LoraDeviceMethodManager.cs 85.00% <100.00%> (+5.00%) ⬆️
...ed/Models/v1.0/LoRaWAN/LoRaCloudToDeviceMessage.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hocinehacherouf hocinehacherouf marked this pull request as ready for review August 8, 2022 10:01
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner August 8, 2022 10:01
_ = m.Content.Should().BeAssignableTo<JsonContent>();
var body = (JsonContent) m.Content;
var loRaCloudToDeviceMessage = (LoRaCloudToDeviceMessage)body?.Value;
_ = loRaCloudToDeviceMessage.Should().NotBeNull();

Check warning

Code scanning / CodeQL

Dereferenced variable may be null

Variable [loRaCloudToDeviceMessage](1) may be null here as suggested by [this](2) null check. Variable [loRaCloudToDeviceMessage](1) may be null here as suggested by [this](3) null check. Variable [loRaCloudToDeviceMessage](1) may be null here as suggested by [this](4) null check.
@hocinehacherouf hocinehacherouf merged commit 74a6ab8 into main Aug 8, 2022
@hocinehacherouf hocinehacherouf deleted the feature/907_alway_send_confirmed_property_on_command branch August 8, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Always send confirmed property when executing commands
2 participants