Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #811 - Add available frequency plans from API and remove hardcode… #1038

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Aug 8, 2022

…d frequency plans from Web pages

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand marked this pull request as ready for review August 8, 2022 09:48
@kbeaugrand kbeaugrand requested a review from a team as a code owner August 8, 2022 09:48
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #1038 (169f1a5) into main (74a6ab8) will increase coverage by 0.05%.
The diff coverage is 92.68%.

@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
+ Coverage   85.24%   85.30%   +0.05%     
==========================================
  Files         177      179       +2     
  Lines        5810     5847      +37     
==========================================
+ Hits         4953     4988      +35     
- Misses        857      859       +2     
Impacted Files Coverage Δ
.../LoRaWAN/Concentrator/ConcentratorDetailPage.razor 79.71% <80.00%> (+0.34%) ⬆️
.../LoRaWAN/Concentrator/CreateConcentratorPage.razor 95.45% <88.88%> (-1.69%) ⬇️
...ient/Services/LoRaWanConcentratorsClientService.cs 100.00% <100.00%> (ø)
...rs/v1.0/LoRaWAN/LoRaWANFrequencyPlansController.cs 100.00% <100.00%> (ø)
...Portal/Shared/Models/v1.0/LoRaWAN/FrequencyPlan.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kbeaugrand kbeaugrand force-pushed the feature/make_frequency_plans_dynamic branch from fc4d296 to d27bc14 Compare August 8, 2022 10:22
@kbeaugrand kbeaugrand enabled auto-merge (squash) August 8, 2022 10:30
@kbeaugrand kbeaugrand force-pushed the feature/make_frequency_plans_dynamic branch from d27bc14 to b5de69b Compare August 8, 2022 10:50
@kbeaugrand kbeaugrand force-pushed the feature/make_frequency_plans_dynamic branch from b5de69b to 169f1a5 Compare August 8, 2022 10:50
@kbeaugrand kbeaugrand merged commit 92f8ec4 into main Aug 8, 2022
@kbeaugrand kbeaugrand deleted the feature/make_frequency_plans_dynamic branch August 8, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants