Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #969 - Refactor LoRa Device model and LoRaDevice classes #1056

Merged

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Aug 9, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand force-pushed the refactor/refactor_loradevicemodel_and_loradevice_classes branch 3 times, most recently from 1ede5b9 to 8cf6ec7 Compare August 10, 2022 08:21
@kbeaugrand kbeaugrand marked this pull request as ready for review August 10, 2022 08:22
@kbeaugrand kbeaugrand requested a review from a team as a code owner August 10, 2022 08:22
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1056 (36407bb) into main (728e11c) will increase coverage by 0.01%.
The diff coverage is 76.08%.

@@            Coverage Diff             @@
##             main    #1056      +/-   ##
==========================================
+ Coverage   85.46%   85.47%   +0.01%     
==========================================
  Files         179      180       +1     
  Lines        5861     5909      +48     
==========================================
+ Hits         5009     5051      +42     
- Misses        852      858       +6     
Impacted Files Coverage Δ
...ient/Pages/Devices/DeviceToDuplicateSelector.razor 39.47% <0.00%> (ø)
...al/Client/Validators/LoRaDeviceDetailsValidator.cs 74.28% <0.00%> (-25.72%) ⬇️
...rver/Controllers/v1.0/DeviceModelControllerBase.cs 93.78% <ø> (ø)
...l/Server/Controllers/v1.0/DevicesControllerBase.cs 97.65% <ø> (ø)
...Hub.Portal/Server/Mappers/LoRaDeviceModelMapper.cs 100.00% <ø> (ø)
...ureIoTHub.Portal/Shared/Models/v1.0/DeviceModel.cs 100.00% <ø> (ø)
...Portal/Client/Pages/Devices/CreateDevicePage.razor 63.75% <65.62%> (+0.49%) ⬆️
...ent/Pages/DeviceModels/DeviceModelDetailPage.razor 69.44% <68.00%> (+1.81%) ⬆️
...al/Shared/Models/v1.0/LoRaWAN/LoRaDeviceDetails.cs 96.77% <88.88%> (-3.23%) ⬇️
...Portal/Client/Pages/Devices/DeviceDetailPage.razor 72.28% <95.00%> (+7.35%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kbeaugrand kbeaugrand force-pushed the refactor/refactor_loradevicemodel_and_loradevice_classes branch from 8cf6ec7 to dd946fe Compare August 10, 2022 10:00
@hocinehacherouf hocinehacherouf force-pushed the refactor/refactor_loradevicemodel_and_loradevice_classes branch from dd946fe to 5afcf05 Compare August 10, 2022 12:48
@kbeaugrand kbeaugrand marked this pull request as draft August 10, 2022 13:57
@kbeaugrand kbeaugrand force-pushed the refactor/refactor_loradevicemodel_and_loradevice_classes branch 2 times, most recently from d16de76 to 255121d Compare August 10, 2022 13:58
@kbeaugrand kbeaugrand force-pushed the refactor/refactor_loradevicemodel_and_loradevice_classes branch 2 times, most recently from c1b1a21 to 7662556 Compare August 11, 2022 07:24
@kbeaugrand kbeaugrand marked this pull request as ready for review August 11, 2022 07:25
@hocinehacherouf hocinehacherouf force-pushed the refactor/refactor_loradevicemodel_and_loradevice_classes branch from 1bb0b37 to 36407bb Compare August 11, 2022 15:10
@hocinehacherouf hocinehacherouf merged commit 5edbd1a into main Aug 11, 2022
@hocinehacherouf hocinehacherouf deleted the refactor/refactor_loradevicemodel_and_loradevice_classes branch August 11, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Reorganize LoRaDeviceDetails and LoRaDeviceModel models
2 participants