Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1101 - Add concentrator device Id in concentrator list #1103

Merged

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Aug 18, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand force-pushed the feature/1101-display-device-id-in-concentrator-list branch from 5f99700 to 5f024f9 Compare August 18, 2022 13:38
@kbeaugrand kbeaugrand marked this pull request as ready for review August 18, 2022 13:38
@kbeaugrand kbeaugrand requested a review from a team as a code owner August 18, 2022 13:38
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Base: 85.47% // Head: 85.47% // No change to project coverage 👍

Coverage data is based on head (b80c1b9) compared to base (2caf5f7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1103   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files         180      180           
  Lines        5909     5909           
=======================================
  Hits         5051     5051           
  Misses        858      858           
Impacted Files Coverage Δ
...es/LoRaWAN/Concentrator/ConcentratorListPage.razor 70.49% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand force-pushed the feature/1101-display-device-id-in-concentrator-list branch from 5f024f9 to b80c1b9 Compare August 18, 2022 13:54
@kbeaugrand kbeaugrand merged commit c6067fa into main Aug 18, 2022
@kbeaugrand kbeaugrand deleted the feature/1101-display-device-id-in-concentrator-list branch August 18, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants