Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Clip device names in card on small width screens #1104

Conversation

ChristopheRib63
Copy link
Contributor

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Base: 85.47% // Head: 85.47% // No change to project coverage 👍

Coverage data is based on head (b83d80f) compared to base (c6067fa).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1104   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files         180      180           
  Lines        5909     5909           
=======================================
  Hits         5051     5051           
  Misses        858      858           
Impacted Files Coverage Δ
...Portal/Client/Pages/Devices/DeviceDetailPage.razor 72.28% <100.00%> (ø)
...lient/Pages/EdgeDevices/EdgeDeviceDetailPage.razor 90.81% <100.00%> (ø)
.../LoRaWAN/Concentrator/ConcentratorDetailPage.razor 79.71% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand self-requested a review August 19, 2022 08:53
@ChristopheRib63 ChristopheRib63 marked this pull request as ready for review August 19, 2022 08:53
@ChristopheRib63 ChristopheRib63 requested a review from a team as a code owner August 19, 2022 08:53
@ChristopheRib63 ChristopheRib63 enabled auto-merge (squash) August 19, 2022 08:54
@kbeaugrand kbeaugrand changed the title Fix: Names can exceed its frame Fix: Clip device names in card on small width screens Aug 19, 2022
@kbeaugrand kbeaugrand force-pushed the Fixvisual/1092_In_Details_Pages_Names_Can_Exceed_Its_Frame branch from 727972b to b83d80f Compare August 19, 2022 08:55
@ChristopheRib63 ChristopheRib63 merged commit 7332402 into main Aug 19, 2022
@ChristopheRib63 ChristopheRib63 deleted the Fixvisual/1092_In_Details_Pages_Names_Can_Exceed_Its_Frame branch August 19, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants