Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1108 - Add information message on creation and update to inform … #1120

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Aug 24, 2022

…that changes might take some minutes to be visible on page lists

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

…that changes might take some minutes to be visible on page lists
@kbeaugrand kbeaugrand marked this pull request as ready for review August 24, 2022 08:06
@kbeaugrand kbeaugrand requested a review from a team as a code owner August 24, 2022 08:06
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Base: 85.99% // Head: 85.99% // No change to project coverage 👍

Coverage data is based on head (6956b0e) compared to base (0183f83).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1120   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files         196      196           
  Lines        6491     6491           
=======================================
  Hits         5582     5582           
  Misses        909      909           
Impacted Files Coverage Δ
...ent/Pages/EdgeDevices/CreateEdgeDeviceDialog.razor 25.00% <0.00%> (ø)
...Portal/Client/Pages/Devices/CreateDevicePage.razor 63.75% <100.00%> (ø)
...Portal/Client/Pages/Devices/DeviceDetailPage.razor 72.28% <100.00%> (ø)
...lient/Pages/EdgeDevices/EdgeDeviceDetailPage.razor 90.81% <100.00%> (ø)
.../LoRaWAN/Concentrator/ConcentratorDetailPage.razor 79.71% <100.00%> (ø)
.../LoRaWAN/Concentrator/CreateConcentratorPage.razor 95.45% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -88,7 +88,7 @@
mockIoTEdgeDevice.DeviceId.Equals(device.DeviceId, StringComparison.Ordinal))))
.Returns(Task.CompletedTask);

_ = this.mockSnackbarService.Setup(c => c.Add($"Device {this.mockdeviceId} has been successfully updated!", Severity.Success, null)).Returns((Snackbar)null);
_ = this.mockSnackbarService.Setup(c => c.Add($"Device {this.mockdeviceId} has been successfully updated!\r\nPlease note that changes might take some minutes to be visible in the list...", Severity.Success, null)).Returns((Snackbar)null);

Check warning

Code scanning / CodeQL

Useless upcast

There is no need to upcast from [null](1) to [Snackbar](2) - the conversion can be done implicitly.
@kbeaugrand kbeaugrand merged commit 2dde04f into main Aug 24, 2022
@kbeaugrand kbeaugrand deleted the fix/1108_add_information_message branch August 24, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Renaming a device is only visible after a few minutes
2 participants