-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1118_-_Select the edge model at device creation #1125
Feature/1118_-_Select the edge model at device creation #1125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sben65 , I see also an issue when clicking to connect button:
Unhandled exception rendering component: Arg_NullReferenceException
System.NullReferenceException: Arg_NullReferenceException
at AzureIoTHub.Portal.Client.Pages.EdgeDevices.ConnectionStringDialog.<BuildRenderTree>b__0_7(RenderTreeBuilder __builder6)
at Microsoft.AspNetCore.Components.Rendering.RenderTreeBuilder.AddContent(Int32 , RenderFragment )
at MudBlazor.MudItem.BuildRenderTree(RenderTreeBuilder __builder)
at Microsoft.AspNetCore.Components.ComponentBase.<.ctor>b__6_0(RenderTreeBuilder builder)
at Microsoft.AspNetCore.Components.Rendering.ComponentState.RenderIntoBatch(RenderBatchBuilder , RenderFragment , Exception& )
This issue is already present in the code base. I think this might be resolved by making the popup displayed with await (see the device details page for more info)
src/AzureIoTHub.Portal/Client/Pages/EdgeDevices/CreateEdgeDevicePage.razor
Show resolved
Hide resolved
src/AzureIoTHub.Portal/Client/Pages/EdgeDevices/EdgeDeviceListPage.razor
Show resolved
Hide resolved
51cb081
to
d7ad09c
Compare
d7ad09c
to
bfc9f84
Compare
Codecov ReportBase: 85.99% // Head: 85.99% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1125 +/- ##
=======================================
Coverage 85.99% 85.99%
=======================================
Files 196 196
Lines 6491 6491
=======================================
Hits 5582 5582
Misses 909 909 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/AzureIoTHub.Portal.Tests.Unit/Client/Pages/EdgeDevices/EdgeDeviceDetailPageTests.cs
Fixed
Show fixed
Hide fixed
src/AzureIoTHub.Portal.Tests.Unit/Client/Pages/EdgeDevices/EdgeDeviceDetailPageTests.cs
Fixed
Show fixed
Hide fixed
src/AzureIoTHub.Portal.Tests.Unit/Client/Pages/EdgeDevices/EdgeDeviceDetailPageTests.cs
Fixed
Show fixed
Hide fixed
72162e6
to
c2e749b
Compare
Description
What's new?
What kind of change does this PR introduce?