Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1118_-_Select the edge model at device creation #1125

Merged

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Aug 25, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@Sben65 Sben65 requested a review from a team as a code owner August 25, 2022 14:28
@Sben65 Sben65 closed this Aug 25, 2022
@Sben65 Sben65 reopened this Aug 25, 2022
Copy link
Member

@kbeaugrand kbeaugrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sben65 , I see also an issue when clicking to connect button:

Unhandled exception rendering component: Arg_NullReferenceException
System.NullReferenceException: Arg_NullReferenceException
   at AzureIoTHub.Portal.Client.Pages.EdgeDevices.ConnectionStringDialog.<BuildRenderTree>b__0_7(RenderTreeBuilder __builder6)
   at Microsoft.AspNetCore.Components.Rendering.RenderTreeBuilder.AddContent(Int32 , RenderFragment )
   at MudBlazor.MudItem.BuildRenderTree(RenderTreeBuilder __builder)
   at Microsoft.AspNetCore.Components.ComponentBase.<.ctor>b__6_0(RenderTreeBuilder builder)
   at Microsoft.AspNetCore.Components.Rendering.ComponentState.RenderIntoBatch(RenderBatchBuilder , RenderFragment , Exception& )

This issue is already present in the code base. I think this might be resolved by making the popup displayed with await (see the device details page for more info)

@kbeaugrand kbeaugrand force-pushed the Feature/1118_-_Select_the_edge_model_at_device_creation branch 2 times, most recently from 51cb081 to d7ad09c Compare August 26, 2022 06:30
@Sben65 Sben65 force-pushed the Feature/1118_-_Select_the_edge_model_at_device_creation branch from d7ad09c to bfc9f84 Compare August 26, 2022 09:00
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Base: 85.99% // Head: 85.99% // No change to project coverage 👍

Coverage data is based on head (71dc4ac) compared to base (71dc4ac).
Patch has no changes to coverable lines.

❗ Current head 71dc4ac differs from pull request most recent head c2e749b. Consider uploading reports for the commit c2e749b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1125   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files         196      196           
  Lines        6491     6491           
=======================================
  Hits         5582     5582           
  Misses        909      909           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand force-pushed the Feature/1118_-_Select_the_edge_model_at_device_creation branch from 72162e6 to c2e749b Compare August 26, 2022 14:28
@kbeaugrand kbeaugrand merged commit 90fde5c into main Aug 26, 2022
@kbeaugrand kbeaugrand deleted the Feature/1118_-_Select_the_edge_model_at_device_creation branch August 26, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: [Edge device] - Select the edge model at device creation
2 participants