Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #980 - Refactor LoRaWAN Concentrators Controller #1133

Merged
merged 4 commits into from
Aug 27, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Aug 27, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Base: 86.00% // Head: 86.13% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (a5dff5f) compared to base (90fde5c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1133      +/-   ##
==========================================
+ Coverage   86.00%   86.13%   +0.13%     
==========================================
  Files         196      197       +1     
  Lines        6625     6659      +34     
==========================================
+ Hits         5698     5736      +38     
+ Misses        927      923       -4     
Impacted Files Coverage Δ
...ers/v1.0/LoRaWAN/LoRaWANConcentratorsController.cs 91.66% <100.00%> (+1.54%) ⬆️
...rtal/Server/Services/LoRaWANConcentratorService.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand marked this pull request as ready for review August 27, 2022 11:34
@kbeaugrand kbeaugrand requested a review from a team as a code owner August 27, 2022 11:34
@kbeaugrand kbeaugrand force-pushed the fix/980_Refactor_LoRaWan_concentrator_controller branch from 8e40101 to ae40f31 Compare August 27, 2022 12:06
@kbeaugrand kbeaugrand force-pushed the fix/980_Refactor_LoRaWan_concentrator_controller branch from ae40f31 to 2849c37 Compare August 27, 2022 12:18
@kbeaugrand kbeaugrand enabled auto-merge (squash) August 27, 2022 12:20
@kbeaugrand kbeaugrand force-pushed the fix/980_Refactor_LoRaWan_concentrator_controller branch from 2849c37 to a5dff5f Compare August 27, 2022 13:32
@kbeaugrand kbeaugrand disabled auto-merge August 27, 2022 13:39
@kbeaugrand kbeaugrand merged commit 302b9f1 into main Aug 27, 2022
@kbeaugrand kbeaugrand deleted the fix/980_Refactor_LoRaWan_concentrator_controller branch August 27, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor LoRaWanConcentratorsController
1 participant