Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1136 HTTP 500 Add LoRaWan device service to depency injection #1137

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

JeremyTremblay2
Copy link
Contributor

@JeremyTremblay2 JeremyTremblay2 commented Aug 29, 2022

Description

What's new?

-Fix #1136

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@JeremyTremblay2 JeremyTremblay2 requested a review from a team as a code owner August 29, 2022 09:42
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Base: 86.14% // Head: 86.14% // No change to project coverage 👍

Coverage data is based on head (6f89f50) compared to base (e94ffb6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1137   +/-   ##
=======================================
  Coverage   86.14%   86.14%           
=======================================
  Files         198      198           
  Lines        6667     6667           
=======================================
  Hits         5743     5743           
  Misses        924      924           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JeremyTremblay2 JeremyTremblay2 merged commit 192525f into main Aug 29, 2022
@JeremyTremblay2 JeremyTremblay2 deleted the fix/1136-fixhttp500 branch August 29, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: HTTP 500 Error in device detail page
2 participants