Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1138 edge model deployment invalid format #1143

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

JeremyTremblay2
Copy link
Contributor

@JeremyTremblay2 JeremyTremblay2 commented Aug 30, 2022

Description

What's new?

-Fix #1138

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@JeremyTremblay2 JeremyTremblay2 requested a review from a team as a code owner August 30, 2022 08:23
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 86.14% // Head: 86.13% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (3bb3929) compared to base (6772821).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
- Coverage   86.14%   86.13%   -0.01%     
==========================================
  Files         198      198              
  Lines        6667     6665       -2     
==========================================
- Hits         5743     5741       -2     
  Misses        924      924              
Impacted Files Coverage Δ
...els/v1.0/IoTEdgeModule/EdgeHubPropertiesDesired.cs 100.00% <ø> (ø)
.../AzureIoTHub.Portal/Server/Helpers/ConfigHelper.cs 83.52% <100.00%> (-0.10%) ⬇️
...l/Shared/Models/v1.0/IoTEdgeModule/ConfigModule.cs 100.00% <100.00%> (ø)
...s/v1.0/IoTEdgeModule/EdgeAgentPropertiesDesired.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand merged commit 6227ce0 into main Aug 30, 2022
@kbeaugrand kbeaugrand deleted the fix/1138_edge_model_deployment_invalid_format branch August 30, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Edge Model deployment has invalid format
2 participants